Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 460450 - www-client/firefox-17.0.3 fails to install with ld.gold
Summary: www-client/firefox-17.0.3 fails to install with ld.gold
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords: STABLE
Depends on:
Blocks:
 
Reported: 2013-03-05 21:30 UTC by Julian Ospald
Modified: 2013-04-10 13:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
firefox-17.0.3:20130305-195628.log.xz (firefox-17.0.3:20130305-195628.log.xz,294.41 KB, application/x-xz)
2013-03-05 21:30 UTC, Julian Ospald
Details
firefox-17.0.3:20130306-140349-noccache.log.xz (firefox-17.0.3:20130306-140349.log.xz,294.98 KB, application/x-xz)
2013-03-06 15:02 UTC, Julian Ospald
Details
Fix elfhack to support gold linker (ld-gold.patch,2.45 KB, patch)
2013-03-09 13:31 UTC, Jory A. Pratt
Details | Diff
firefox-19.0.2 does not like it, elfhack patch fails - build log snippet (file_460450.txt,6.29 KB, text/plain)
2013-03-16 12:55 UTC, cmuelle8
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2013-03-05 21:30:39 UTC
Created attachment 341042 [details]
firefox-17.0.3:20130305-195628.log.xz

=== If you get failures below, please file a bug describing the error
=== and your environment (compiler and linker versions), and use
=== --disable-elf-hack until this is fixed.
===
cd ../../dist/bin; find . -name "*.so" | xargs ../../build/unix/elfhack/elfhack
elfhack: /var/tmp/portage/www-client/firefox-17.0.3/work/mozilla-esr17/build/unix/elfhack/elf.cpp:262: Elf::Elf(std::ifstream&): Assertion `segment->getMemSize() == phdr.p_memsz' failed.
xargs: ../../build/unix/elfhack/elfhack: terminated by signal 6
make[1]: *** [elfhack] Error 125
make[1]: Leaving directory `/var/tmp/portage/www-client/firefox-17.0.3/work/mozilla-esr17/obj-x86_64-unknown-linux-gnu/browser/installer'
make: *** [install] Error 2
Comment 1 Julian Ospald 2013-03-05 21:31:04 UTC
Portage 2.2.0_alpha166 (default/linux/amd64/13.0, gcc-4.6.3, glibc-2.15-r3, 3.4.9-gnu-ck3 x86_64)
=================================================================
System uname: Linux-3.4.9-gnu-ck3-x86_64-Intel-R-_Core-TM-2_CPU_6400_@_2.13GHz-with-gentoo-2.1
KiB Mem:     4047728 total,     81532 free
KiB Swap:    2047996 total,   1615176 free
Timestamp of tree: Tue, 05 Mar 2013 16:15:01 +0000
ld GNU gold (GNU Binutils 2.22) 1.11
distcc 3.1 x86_64-pc-linux-gnu [disabled]
ccache version 3.1.9 [enabled]
app-shells/bash:          4.2_p37
dev-java/java-config:     2.1.12-r1
dev-lang/python:          2.5.4-r4, 2.6.8, 2.7.3-r2, 3.1.5, 3.2.3, 3.3.0-r1
dev-util/ccache:          3.1.9
dev-util/cmake:           2.8.9
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.10.3, 1.11.1, 1.12.6, 1.13.1
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.4.7, 4.5.4, 4.6.3, 4.7.2
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.6 (virtual/os-headers)
sys-libs/glibc:           2.15-r3
Repositories: gentoo gentoo-zh neurogeek sunrise hasufell arx-libertatis crossdev hasufell-overlay science
Installed sets: @bleh, @optional, @steam
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=core2 -O2 -pipe -Wall -g"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/applications /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="${EPREFIX}/etc/gconf /etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=core2 -O2 -pipe -Wall -g"
DISTDIR="/home/distfiles"
EMERGE_DEFAULT_OPTS="--usepkg"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildpkg ccache collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch protect-owned sandbox sfperms sign split-log splitdebug strict test-fail-continue unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="ftp://mirror.netcologne.de/gentoo/ ftp://gentoo.imj.fr/pub/gentoo/ ftp://de-mirror.org/gentoo/"
INSTALL_MASK="/usr/lib/systemd/*"
LANG="de_DE.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j2"
PKGDIR="/home/packages"
PORTAGE_COMPRESS="xz"
PORTAGE_COMPRESS_FLAGS="-z -9"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/gentoo-zh /var/lib/layman/neurogeek /var/lib/layman/sunrise /var/lib/layman/hasufell /var/lib/layman/arx-libertatis /usr/local/crossdev /usr/local/portage /usr/local/portage-science"
SYNC="rsync://rsync1.de.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa amd64 apng bash-completion berkdb bzip2 cairo cdr cli consolekit cracklib crypt cscope css cxx dbus dri dv dvd dvdr exif fat ffmpeg flac fontconfig fortran gdbm gif gpm gstreamer hddtemp iconv icq ipv6 jabber java jpeg jpeg2k lame libnotify lm_sensors matroska mmx modules mp3 mp4 mpeg mudflap multilib musepack ncurses nls nptl nsplugin ntfs ogg opengl openmp oscar pam pcre pdf png policykit python raw readline sdl session sound sse sse2 ssl ssse3 svg tcpd tiff timidity truetype udev unicode usb v4l vcd vdpau vim-syntax vnc vorbis wavpack wmf x264 xv xvid xvmc zlib" ABI_X86="64 32" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev keyboard mouse joystick" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="pdfimport presenter-console presenter-minimizer wiki-publisher" LINGUAS="en de" NETBEANS_MODULES="*" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_5 python2_6 python2_7 python3_1 python3_2" QEMU_SOFTMMU_TARGETS="i386 ppc ppc64 x86_64" QEMU_USER_TARGETS="arm i386 x86_64" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
USE_PYTHON="2.5 2.6 2.7 3.1 3.2"
Unset:  CPPFLAGS, CTARGET, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_RSYNC_EXTRA_OPTS
Comment 2 Jory A. Pratt gentoo-dev 2013-03-06 13:29:55 UTC
Disable ccache and retest, we are not gonna chase issues with ccache enabled for builds.
Comment 3 Julian Ospald 2013-03-06 14:59:05 UTC
not a ccache issue.
Comment 4 Julian Ospald 2013-03-06 15:02:02 UTC
Created attachment 341116 [details]
firefox-17.0.3:20130306-140349-noccache.log.xz
Comment 5 Julian Ospald 2013-03-07 20:07:22 UTC
seems to work with ld.bfd
Comment 6 Jory A. Pratt gentoo-dev 2013-03-09 13:31:35 UTC
Created attachment 341436 [details, diff]
Fix elfhack to support gold linker

Please test with ld.gold and let me know, if all is well will get it landed.
Comment 7 Julian Ospald 2013-03-09 22:39:01 UTC
(In reply to comment #6)
> Created attachment 341436 [details, diff] [details, diff]
> Fix elfhack to support gold linker
> 
> Please test with ld.gold and let me know, if all is well will get it landed.

that works
Comment 8 cmuelle8 2013-03-16 12:55:17 UTC
Created attachment 342240 [details]
firefox-19.0.2 does not like it, elfhack patch fails - build log snippet

I did not try firefox-17, but applying this patch to the elfhack code of firefox-19 (which patches fine), does not seem to completely solve the gold linker problems.  This is with GCC-4.7.2-r1 on x86 atom, gold linker and lto enabled.

I ran the LD_PRELOAD tests separately after compile failed.  test-ctors.so fails, while test-array.so passes.

# LD_PRELOAD=/var/tmp/paludis/www-client-firefox-19.0.2/work/mozilla-release/obj-i686-pc-linux-gnu/build/unix/elfhack/test-ctors.so /var/tmp/paludis/www-client-firefox-19.0.2/work/mozilla-release/obj-i686-pc-linux-gnu/build/unix/elfhack/dummy
FAIL

# LD_PRELOAD=/var/tmp/paludis/www-client-firefox-19.0.2/work/mozilla-release/obj-i686-pc-linux-gnu/build/unix/elfhack/test-array.so /var/tmp/paludis/www-client-firefox-19.0.2/work/mozilla-release/obj-i686-pc-linux-gnu/build/unix/elfhack/dummy
PASS


.. retrying w/o gold



Greetings
Comment 9 Jory A. Pratt gentoo-dev 2013-03-16 13:22:54 UTC
(In reply to comment #8)
> Created attachment 342240 [details]
> firefox-19.0.2 does not like it, elfhack patch fails - build log snippet
> 
> I did not try firefox-17, but applying this patch to the elfhack code of
> firefox-19 (which patches fine), does not seem to completely solve the gold
> linker problems.  This is with GCC-4.7.2-r1 on x86 atom, gold linker and lto
> enabled.
> 
> I ran the LD_PRELOAD tests separately after compile failed.  test-ctors.so
> fails, while test-array.so passes.
> 
> #
> LD_PRELOAD=/var/tmp/paludis/www-client-firefox-19.0.2/work/mozilla-release/
> obj-i686-pc-linux-gnu/build/unix/elfhack/test-ctors.so
> /var/tmp/paludis/www-client-firefox-19.0.2/work/mozilla-release/obj-i686-pc-
> linux-gnu/build/unix/elfhack/dummy
> FAIL
> 
> #
> LD_PRELOAD=/var/tmp/paludis/www-client-firefox-19.0.2/work/mozilla-release/
> obj-i686-pc-linux-gnu/build/unix/elfhack/test-array.so
> /var/tmp/paludis/www-client-firefox-19.0.2/work/mozilla-release/obj-i686-pc-
> linux-gnu/build/unix/elfhack/dummy
> PASS
> 
> 
> .. retrying w/o gold
> 
> 
> 
> Greetings

Wrong bug completely, if you are having trouble with atom build see bug 461694
Comment 10 cmuelle8 2013-03-16 21:11:04 UTC
(In reply to comment #9)
> Wrong bug completely, if you are having trouble with atom build see bug
> 461694

Thx, but I created #461694. it's about a different issue which is fixable by a certain gcc commit.

Nevertheless, elfhack/gold problems are completely the same with 19* as in 17*, this is why I tried the patch provided.  Please try to get a picture of the whole story before you're nitpicking..


Greetings
Comment 11 Jory A. Pratt gentoo-dev 2013-03-17 00:49:31 UTC
(In reply to comment #10)
> (In reply to comment #9)
> > Wrong bug completely, if you are having trouble with atom build see bug
> > 461694
> 
> Thx, but I created #461694. it's about a different issue which is fixable by
> a certain gcc commit.
> 
> Nevertheless, elfhack/gold problems are completely the same with 19* as in
> 17*, this is why I tried the patch provided.  Please try to get a picture of
> the whole story before you're nitpicking..
> 
> 
> Greetings

Nice to know. As you have seen fit to put me in my place feel free to get with mozilla herd so you can become a maintainer for them. It is time I step aside and let you *kids* take over as you seem to know much more then those who actively maintain the package.
Comment 12 Maxim Britov 2013-03-23 17:15:56 UTC
Met this too, with FF 19.0.2
Successfully compiled with provided patch.
just fyi. thanks
Comment 13 Jory A. Pratt gentoo-dev 2013-03-24 19:59:45 UTC
Fixed in esr builds. Will be addressed in non-esr builds in fx-20.0
Comment 14 Jory A. Pratt gentoo-dev 2013-04-10 13:43:35 UTC
Fixed for a while now.