Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 459086 - media-sounds/google-musicmanager: install png icons and use bundled desktop file
Summary: media-sounds/google-musicmanager: install png icons and use bundled desktop file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Christoph Junghans (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 459068
  Show dependency tree
 
Reported: 2013-02-25 01:12 UTC by Mike Gilbert
Modified: 2013-03-07 18:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuld patch (google-musicmanager.patch,888 bytes, patch)
2013-02-25 01:12 UTC, Mike Gilbert
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2013-02-25 01:12:38 UTC
Created attachment 340038 [details, diff]
Ebuld patch

This will make the icon appear a bit less ugly in menus.
Comment 1 Julian Ospald 2013-02-25 02:15:13 UTC
inherit ... gnome2-utils ...
...
pkg_preinst() { gnome2_icon_savelist ;}
pkg_postinst() { gnome2_icon_cache_update ; }
pkg_postrm() { gnome2_icon_cache_update ; }
Comment 2 Mike Gilbert gentoo-dev 2013-02-25 02:16:46 UTC
Yeah, you could also add touch "${ROOT}/usr/share/icons/hicolor" to pkg_postinst to trigger a KDE icon cache update.
Comment 3 Christoph Junghans (RETIRED) gentoo-dev 2013-02-26 03:29:41 UTC
patch added in google-musicmanager-1.0.55.7425_beta-r2. (Feel free to touch my packages for such trivialities.)
Comment 4 Agostino Sarubbo gentoo-dev 2013-03-07 18:07:27 UTC
is this fixed? can we proceed with the stabiliz.?
Comment 5 Christoph Junghans (RETIRED) gentoo-dev 2013-03-07 18:23:46 UTC
(In reply to comment #1)
> inherit ... gnome2-utils ...
> ...
> pkg_preinst() { gnome2_icon_savelist ;}
> pkg_postinst() { gnome2_icon_cache_update ; }
> pkg_postrm() { gnome2_icon_cache_update ; }

(In reply to comment #2)
> Yeah, you could also add touch "${ROOT}/usr/share/icons/hicolor" to
> pkg_postinst to trigger a KDE icon cache update.

I am unclear about these two comments, is it needed? I am on XFCE, so I don't really see a need for it. And why isn't there a eutils function to refresh the icon cache of all desktop environments?
Comment 6 Mike Gilbert gentoo-dev 2013-03-07 18:40:13 UTC
I think it is good enough as-is. If users run into cache problems, they should take whatever action is necessary to trigger a re-cache in their desktop environment of choice.

Solving that problem here is outside the scope of this bug.
Comment 7 Christoph Junghans (RETIRED) gentoo-dev 2013-03-07 18:56:40 UTC
(In reply to comment #6)
> I think it is good enough as-is. If users run into cache problems, they
> should take whatever action is necessary to trigger a re-cache in their
> desktop environment of choice.
> 
> Solving that problem here is outside the scope of this bug.
So then this bug is fixed!