Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 456124 - net-analyzer/munin-2.0.8-r2 multiple install problems
Summary: net-analyzer/munin-2.0.8-r2 multiple install problems
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sysadmin Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-08 08:28 UTC by LABBE Corentin
Modified: 2013-02-09 14:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description LABBE Corentin 2013-02-08 08:28:07 UTC
When launching an ebuild install I have this QA:
 * QA Notice: shell script appears to use non-POSIX feature(s):
 *    possible bashism in /etc/init.d/munin-node line 24 (should be 'b = a'):
 *    	[ "$(get_munin_config log_file)" == "Sys::Syslog" ] && \
 *    		use logger
 *    possible bashism in /etc/init.d/munin-node line 33 (kill -[0-9] or -[A-Z]):
 *        kill -HUP `cat ${pidfile}`

Also in /etc/munin/munin.conf a variable is not expanded
# cgitmpdir @@CGITMPDIR@@


In pkg_postinst, a chown is made on a invalid path:
"${ROOT}"/var/log/munin-cgi-{graph,html}.log instead of
"${ROOT}"/var/log/munin/munin-cgi-{graph,html}.log
Perhaps you could also use fowner or add a missing "|| die"


Reproducible: Always
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2013-02-09 14:18:55 UTC
Thanks, good catch.

The non-expanded var will be fixed when that finally get upstream, I've fixed the double equal (silly me, I should have known), and begrudgingly the kill call (which is NOT a bashism, okay it might not work with Busybox, but it's not a problem with BASH).

Resolved in 2.0.11.1 (committing in a moment).