455536 – cannot edit existing activities in hamster-applet-2.32.1

Bug 455536 - cannot edit existing activities in hamster-applet-2.32.1

Summary: cannot edit existing activities in hamster-applet-2.32.1

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] GNOME (show other bugs)
Hardware:	All Linux

Importance:	Normal minor (vote)
Assignee:	Gentoo Linux Gnome Desktop Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2013-02-05 00:38 UTC by waynedpj
Modified:	2013-02-18 20:40 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
patch to fix error that prevents existing activities from being edited (hamster-applet-2.32.1-fix-activityentry.py.patch,629 bytes, patch) 2013-02-05 01:47 UTC, waynedpj	Details \| Diff
updated ebuild that applies hamster-applet-2.32.1-fix-activityentry.py.patch (hamster-applet-2.32.1-r1.ebuild,1.84 KB, text/plain) 2013-02-05 01:51 UTC, waynedpj	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description waynedpj 2013-02-05 00:38:29 UTC

simple patch to fix small bug in hamster-applet-2.32.1 that prevents existing activities from being edited.

Reproducible: Always

Comment 1 waynedpj 2013-02-05 01:47:17 UTC

Created attachment 337966 [details, diff]
patch to fix error that prevents existing activities from being edited

very simple fix, already done upstream in newer releases, which unfortunately are not available for GNOME 2.x.

Comment 2 waynedpj 2013-02-05 01:51:20 UTC

Created attachment 337968 [details]
updated ebuild that applies hamster-applet-2.32.1-fix-activityentry.py.patch

Comment 3 waynedpj 2013-02-05 01:54:01 UTC

original error causes the following output:

Traceback (most recent call last):
  File "/usr/bin/hamster-time-tracker", line 254, in _open_edit_activity
    dialogs.edit.show(self.window, fact_id = fact["id"])
  File "/usr/lib64/python2.7/site-packages/hamster/configuration.py", line 98, in show
    dialog = self.get_dialog_class()(parent, **kwargs)
  File "/usr/lib64/python2.7/site-packages/hamster/edit_activity.py", line 119, in __init__
    self.on_in_progress_toggled(self.get_widget("in_progress"))
  File "/usr/lib64/python2.7/site-packages/hamster/edit_activity.py", line 241, in on_in_progress_toggled
    self.validate_fields()
  File "/usr/lib64/python2.7/site-packages/hamster/edit_activity.py", line 279, in validate_fields
    activity_text, temporary = self.new_name.get_value()
  File "/usr/lib64/python2.7/site-packages/hamster/widgets/activityentry.py", line 120, in get_value
    name = "%s@%s" % name, activity['category']
TypeError: not enough arguments for format string

Comment 4 Pacho Ramos gentoo-dev

2013-02-18 20:40:51 UTC

+*hamster-applet-2.32.1-r1 (18 Feb 2013)
+
+  18 Feb 2013; Pacho Ramos <pacho@gentoo.org>
+  +files/hamster-applet-2.32.1-fix-edit.patch, +hamster-applet-2.32.1-r1.ebuild,
+  -files/hamster-applet-2.30.2-fix-import.patch:
+  Fix existing activities edition, bug #455536 by Wayne
+