Bug 455374 – dev-libs/libcdio-paranoia-0.90 fails to compile, linguas issue?

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sebastian Pipping 2013-02-04 00:26:32 UTC]

Created attachment 337864 [details]
Build log

Despite LINGUAS="en_US en" I run into this compilation error, related to a Japanese locale if I am not mistaken:

[..]
make[3]: Entering directory `/var/tmp/portage/dev-libs/libcdio-paranoia-0.90/work/libcdio-paranoia-10.2+0.90/doc/ja'
make[3]: Nothing to be done for `install-exec-am'.
test -z "/usr/share/man/man1" ||  "/var/tmp/portage/dev-libs/libcdio-paranoia-0.90/image//usr/share/man/jp/man1"
/bin/sh: /var/tmp/portage/dev-libs/libcdio-paranoia-0.90/image//usr/share/man/jp/man1: No such file or directory
make[3]: *** [install-man1] Error 127
make[3]: Leaving directory `/var/tmp/portage/dev-libs/libcdio-paranoia-0.90/work/libcdio-paranoia-10.2+0.90/doc/ja'
[..]

Full build log is attached.

[Comment 1 Samuli Suominen (RETIRED) 2013-02-04 07:29:33 UTC]

Can you try adding this line before emake install in src_install() function:

dodir /usr/share/man/jp/man1

Alternatively if that fails then add -j1 to the emake install in src_install()
Because I'm quite sure this is just parallel make failure where the directory isn't created early enough...

[Comment 2 Samuli Suominen (RETIRED) 2013-02-04 07:30:30 UTC]

(The build system of the manpages is ignoring LINGUAS, so it's propably unrelated to this specific failure, although it's a bug on it's own)

[Comment 3 Sebastian Pipping 2013-02-05 00:23:47 UTC]

Created attachment 337960 [details, diff]
Patch for review

It turns out that this is not a parallel make issue: same error with -j1.

This is what happens: Upstream put this code in configure.ac:

  dnl
  dnl Newest automake workaround - needed for multi-language manual pages
  dnl
  AC_SUBST(mkdir_p)

Now ${mkdir_p} is not defined by configure.  As a consequence:

 1. Generated file doc/ja/Makefile says

      mkdir_p =

    rather than

      mkdir_p = /bin/mkdir -p

 2. Line

      test -z "$(man1dir)" || $(mkdir_p) "$(DESTDIR)$(mandir)$(mansubdir)"

    tries to execute "$(DESTDIR)$(mandir)$(mansubdir)" rather than creating
    a directory.  Ouch :-)

What works for me, is this change to configure.ac (also attached as a patch):

  -AC_SUBST(mkdir_p)
  +AC_SUBST(mkdir_p, "${MKDIR_P}")

However, the real fix might be talking to upstream why that line was introduced in the first place.

Also, it remains a mystery to me why doc/ja/Makefile.am is working on such a verbose, low level.  It feels as if I was looking at Makefile.in, instead.  Any ideas?

[Comment 4 Patrick Kursawe (RETIRED) 2013-02-06 19:27:38 UTC]

Patch works fine for me, thanks.

[Comment 5 Samuli Suominen (RETIRED) 2013-02-06 19:47:15 UTC]

+  06 Feb 2013; Samuli Suominen <[e-mail]>
+  libcdio-paranoia-0.90.ebuild, +files/libcdio-paranoia-0.90-mkdir_p.patch:
+  Fix building problem with the japanese manpage wrt #455374 by Sebastian
+  Pipping

Reported upstream here:

https://savannah.gnu.org/bugs/index.php?38273

[Comment 6 Samuli Suominen (RETIRED) 2013-07-22 14:30:56 UTC]

*** Bug 477732 has been marked as a duplicate of this bug. ***

[Comment 7 Samuli Suominen (RETIRED) 2013-07-22 14:31:53 UTC]

Comment on attachment 337960 [details, diff]
Patch for review

I've ditched this patch in favour of using AC_PROG_MKDIR_P and $(MKDIR_P) since bug 477732 was filed. I don't know why I didn't do that in the first place.