Created attachment 337818 [details] build.log va_display_wayland.c: In function 'display_handle_global': va_display_wayland.c:59:23: warning: assignment makes pointer from integer without a cast [enabled by default] va_display_wayland.c:61:18: warning: assignment makes pointer from integer without a cast [enabled by default] va_display_wayland.c: In function 'va_open_display_wayland': va_display_wayland.c:95:9: error: too many arguments to function 'wl_display_get_fd' In file included from ../../va/wayland/va_wayland.h:31:0, from va_display_wayland.c:28: /usr/include/wayland-client.h:141:5: note: declared here I assume libva needs a versioned dependency on <dev-libs/wayland-1.0, since I have dev-libs/wayland-1.0.3 installed and libva built successfully some time ago.
The first two errors seem to stem from wl_display_bind missing in wayland-1.0 - apparently there is no undeclared-function warning...?
This upstream commit fixes it: http://cgit.freedesktop.org/libva/commit/?id=b1cf861a087234eb797c402040403a538adbe0cc The change to configure.ac also confirms that the version of wayland required for libva-1.1.0 was 0.95.0.
Could someone please adjust the DEPEND of libva-1.1.0 to ">=dev-libs/wayland-0.95 <dev-libs/wayland-1.0" and add a -r1 version with DEPEND=">=dev-libs/wayland-1.0" and the mentioned patch? I just tested it using a pre_src_prepare env hack and it works.
applied, thanks!
I hate to say it, but your patch to the ebuild looks wrong. Imagine I build libva against wayland-1 and then downgrade to wayland-0.95 for whatever reason. Now libva will try to use the wayland-1 ABI against the wayland-0.95 library. Which will fail, because they are ABI incompatible. I still think that the correct solution is using DEPEND.
(In reply to comment #5) > I hate to say it, but your patch to the ebuild looks wrong. > > Imagine I build libva against wayland-1 and then downgrade to wayland-0.95 > for whatever reason. Now libva will try to use the wayland-1 ABI against the > wayland-0.95 library. Which will fail, because they are ABI incompatible. > > I still think that the correct solution is using DEPEND. hu? so wayland changes its abi without changing soname ? if that's the case, then its a problem within wayland upstream if that's not the case, then libva will need to be rebuilt and will not try to use the wayland-1 abi, so i dont see any problem here...
(In reply to Alexis Ballier from comment #6) > (In reply to comment #5) > > I hate to say it, but your patch to the ebuild looks wrong. > > > > Imagine I build libva against wayland-1 and then downgrade to wayland-0.95 > > for whatever reason. Now libva will try to use the wayland-1 ABI against the > > wayland-0.95 library. Which will fail, because they are ABI incompatible. > > > > I still think that the correct solution is using DEPEND. > > hu? > so wayland changes its abi without changing soname ? if that's the case, > then its a problem within wayland upstream > > if that's not the case, then libva will need to be rebuilt and will not try > to use the wayland-1 abi, so i dont see any problem here...
