Hi, Is possible add this package to portage? Sunflower is a small and highly customizable twin-panel file manager for Linux with support for plugins. Suggested category: x11-misc/sunflower More information: http://code.google.com/p/sunflower-fm/ https://picasaweb.google.com/MeanEYE.rcf/Sunflower The ebuild is attached. Thanks, Henrique Dias Reproducible: Always
Created attachment 337274 [details] Ebuild for x11-misc/sunflower
Created attachment 337276 [details] Sunflower filemanger source code.
Comment on attachment 337276 [details] Sunflower filemanger source code. There is no need for this. The ebuild should tell where to get it.
(In reply to comment #1) > Created attachment 337274 [details] > Ebuild for x11-misc/sunflower Couple of comments about ebuild: 1) use latest EAPI if possible; 2) use ${PN}, ${PV} or their equivalents in SRC_URI - for easing version bumps; 3) use python-r1 eclass instead on python; 4) get rid of src_prepare - it is useless in your case, just set ${S} properly. Regarding your mail on maintainer-needed@, i add proxy maintainers team to CC. Next time, please send mail to it. maintainer-needed@ alias is for orphaned packages, not for the new one.
Created attachment 337438 [details] New ebuild version with suggested corrections. Thanks Sergey for your comments, Henrique Dias
${PN^} <- that's a bash-4 only feature and thus not allowed you don't provide real multiple abi support, this will need some rework
Created attachment 337448 [details] sunflower-0.1_alpha52.ebuild please test
Created attachment 337452 [details] sunflower put this into FILESDIR
Thanks for a great job and all your good advice. The ebuild work very well. $ sudo emerge --ask x11-misc/sunflower These are the packages that would be merged, in order: Calculating dependencies... done! [ebuild N ] x11-misc/sunflower-0.1_alpha52 PYTHON_TARGETS="python2_7 -python2_6" Would you like to merge these packages? [Yes/No] yes >>> Verifying ebuild manifests >>> Emerging (1 of 1) x11-misc/sunflower-0.1_alpha52 * Sunflower-0.1a-52.tgz SHA256 SHA512 WHIRLPOOL size ;-) ... [ ok ] >>> Unpacking source... >>> Unpacking Sunflower-0.1a-52.tgz to /var/tmp/portage/x11-misc/sunflower-0.1_alpha52/work >>> Source unpacked in /var/tmp/portage/x11-misc/sunflower-0.1_alpha52/work >>> Preparing source in /var/tmp/portage/x11-misc/sunflower-0.1_alpha52/work/Sunflower ... >>> Source prepared. >>> Configuring source in /var/tmp/portage/x11-misc/sunflower-0.1_alpha52/work/Sunflower ... >>> Source configured. >>> Compiling source in /var/tmp/portage/x11-misc/sunflower-0.1_alpha52/work/Sunflower ... >>> Source compiled. >>> Test phase [not enabled]: x11-misc/sunflower-0.1_alpha52 >>> Install sunflower-0.1_alpha52 into /var/tmp/portage/x11-misc/sunflower-0.1_alpha52/image/ category x11-misc * python2.7: running installme >>> Completed installing sunflower-0.1_alpha52 into /var/tmp/portage/x11-misc/sunflower-0.1_alpha52/image/ >>> Installing (1 of 1) x11-misc/sunflower-0.1_alpha52 * Updating desktop mime database ... * Updating icons cache ... [ ok ] * optional dependencies: * dev-python/libgnome-python * media-libs/mutagen * x11-libs/vte:0[python] (terminal support) >>> Recording x11-misc/sunflower in "world" favorites file... * Messages for package x11-misc/sunflower-0.1_alpha52: * optional dependencies: * dev-python/libgnome-python * media-libs/mutagen * x11-libs/vte:0[python] (terminal support) >>> Auto-cleaning packages... >>> No outdated packages were found on your system. * GNU info directory index is up-to-date.
+*sunflower-0.1_alpha52 (31 Jan 2013) + + 31 Jan 2013; Julian Ospald <hasufell@gentoo.org> + +sunflower-0.1_alpha52.ebuild, +files/sunflower, +metadata.xml: + initial import with Henrique Dias wrt #454600 @Henrique Dias: I have added you as proxy-maintainer.
(In reply to comment #6) > ${PN^} <- that's a bash-4 only feature and thus not allowed It is allowed, since stable portage depends on bash-4. We use bash-4 features all the time in eclasses and ebuilds these days.
https://dev.gentoo.org/~ulm/pms/head/pms.html#x1-620006 "The interpreter is assumed to be GNU bash, version 3.2 or later" if I use ${PN^} then I assume version 4.0 or later, so it's invalid
(In reply to comment #12) > https://dev.gentoo.org/~ulm/pms/head/pms.html#x1-620006 > > "The interpreter is assumed to be GNU bash, version 3.2 or later" > > if I use ${PN^} then I assume version 4.0 or later, so it's invalid That's a bug in PMS then. It should be updated to reflect reality. I seem to remember a discussion about this, ~3-4 years ago, where the outcome was that we could use bash-4 features. But we should probably take this to a PMS bug and/or dev ML discussion.
(In reply to comment #13) > (In reply to comment #12) > > https://dev.gentoo.org/~ulm/pms/head/pms.html#x1-620006 > > > > "The interpreter is assumed to be GNU bash, version 3.2 or later" > > > > if I use ${PN^} then I assume version 4.0 or later, so it's invalid > > That's a bug in PMS then. It should be updated to reflect reality. > > I seem to remember a discussion about this, ~3-4 years ago, where the > outcome was that we could use bash-4 features. > > But we should probably take this to a PMS bug and/or dev ML discussion. Err, no. Arfrever used bash-4 features in phase functions but DEPEND-ed on bash-4. That's ugly, however.
PMS says bash 3.2, by this council decision: <http://www.gentoo.org/proj/en/council/meeting-logs/20091109-summary.txt> Since we have EAPI parsing now, we can change to a newer bash version in a future EAPI. See bug 431340.
