Bugzilla Bug 45446

When running singular (2.0.4-r1 and 2.0.5) I get Segmentation fault while doing
normal work. For example when typing the example in
http://www.singular.uni-kl.de/Manual/2-0-4/sing_10.htm#SEC16 it crashes.

Reproducible: Always
Steps to Reproduce:
As described above



Expected Results:  
In my opinion its another path issue. I checked the files and wrote a patch for
singular-2.0.5 which should also work with 2.0.4.
Also, building singular twice is not such a good idea (the standard target is
install, so doing make in source_compile isnt such a good idea). The einstalls
in source_install should be sufficent. I removed also some links to
/var/tmp/portage from the source by this patches.

Portage 2.0.50-r1 (default-x86-1.4, gcc-3.3.2, glibc-2.3.2-r9, 2.6.4-rc1-love3)
=================================================================
System uname: 2.6.4-rc1-love3 i686 AMD Athlon(tm) Processor
Gentoo Base System version 1.4.3.13p1
distcc 2.12.1 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632)
[disabled]
Autoconf: sys-devel/autoconf-2.58-r1
Automake: sys-devel/automake-1.7.7
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-tbird -O2 -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /lib/modules /usr/X11R6/lib/X11/xkb
/usr/kde/2/share/config
/usr/kde/3.1/share/config /usr/kde/3/share/config /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -mcpu=i686 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror/
ftp://ftp.tu-clausthal.de/pub/linux/gentoo http://gentoo.oregonstate.edu/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow X aalib alsa apache2 apm avi berkdb bonobo cdr crypt cups dga doc
dvd
encode esd faad foomaticdb gdbm gif ginac gnome gpm gtk gtk2 gtkhtml guile hbci
imap imlib java jpeg libg++ libwww lirc mad mikmod mmx motif mpeg mysql nas
ncurses nls offensive oggvorbis opengl oss pam pdflib perl png python qt qtmt
quicktime readline samba sasl sdl slang spell sse ssl svga tcltk tcpd tetex
truetype usb v4l x86 xml2 xmms xv xvid zlib"

Created an attachment (id=27823) [edit]
The new patchset for Singular

Okay, I think now just the remove of the make in src_install from the ebuild is
missing.

Um... the removal of _which_ make there? I count quite a few.
Didn't manage to segfault singular the way you described.
But your patch looks very reasonable.

There's exactly one make (make CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}" || die
"make failed", line 52) in src_compile. The rest are einstalls...

By the way, did you add these ${CFLAGS}, ${CXXFLAGS}? do they have any effect?
For the Segfaults: I don't know exactly when they occur, but I more or less
started using Singular yesterday, and it crashed a few times. So I changed to
the static, precompiled version and checked the sources later. I will try today
with the new compiled Singular 2.0.5 again and see what happens

Oh yes, and when your already at it: There a a few filenames/pathnames in
feResource.cc which I didn't find, mostly related to the documentation
(SINGULAR_INFO_FILE (singular.hlp), SINGULAR_IDX_FILE (singular.idx), the html
docu ...). When you've got time, would you mind to check this out?

I suggest you count again :-)
- each einstall is a "make (tons of options) install"
- there are a few more "make"s run when "doc" is in USE

The *FLAGS are used for some compiler runs, not all.
About the pathnames, please tell me a few commands to check if they work or not - I really have no clue how to use singular, just committed the ebuild, for the case you remember bug #26115

makes in __SOURCE_COMPILE__!!!!

The easiest way to check out if the helpfiles are installed, simply start
singular and type "help reduce;". Right now you will get the output:

// ** Could not get IdxFile. 
// ** Either set environment variable SINGULAR_IDX_FILE to IdxFile,
// ** or make sure that IdxFile is at /usr/doc/singular.idx
   ? cannot open `help.cnf`
// ** Displaying help in browser 'dummy'.
// ** Use 'system("--browser", <browser>);' to change browser,
// ** where <browser> can be: "dummy", "emacs".
   ? No functioning help browser available.
   ? error occurred in STDIN line 1: `help reduce;`

while you should get something like this:

> help reduce;
// ** Displaying help in browser 'xinfo'.
// ** Use 'system("--browser", <browser>);' to change browser,
// ** where <browser> can be: "xinfo", "info", "builtin", "dummy", "emacs".
running `xterm -e info -f
/home/wolfs/projects/Singular/Singular/2-0-5/info/singular.hlp --node='reduce'
&`

I referred to your comment #2 where you said that you "think now just the
remove of the make in src_install from the ebuild is missing", and I asked of
which one. So please stop screaming and thanks for comment #9 :-)

sorry, typing and thinking don't coincide always... I meant src_compile

Just added -r2 which actually gives me some reasonable output when I try "help
reduce;" - could you please check what I broke this time? :-)

O.K., lets try it with 

{"xterm",     'X',    feResBinary,"XTERM",                "%d/X11R6/bin/xterm",             ""},

instead of 

{"xterm",     'X',    feResBinary,"XTERM",                "%b/X11R6/bin/xterm",             ""},

(its in singular-2.0.5-r2-gentoo.diff line 101)

Ok, should be enough for now. Please re-open this bug if you find something
else. Thanks alot.

in singular-2.0.5-r3.ebuild you have to replace 

epatch  $FILESDIR/${P}-r2-gentoo.diff

with

epatch  $FILESDIR/${P}-r3-gentoo.diff
                      ^^^^

Ouch. This is the "this should definitely not happen" category of errors.
Thanks.

Created an attachment (id=28004) [edit]
A few changes to the ebuild (mainly for the online help)

Finally i checked to more things out: The hmtl weren't installed because they
were created to late and have the extension .htm. And the missing file help.cnf
was in the LIB directory. I also added the file COPYING in the LIB-dir to the
installed files, because it includes the copyright of the Libraries. That
should do it for now.

Thank you very much again. -r4 will be there soon. Quite a busy week for
Singular :-)