Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 454256 - net-analyzer/bwping-1.7 - should not automagically detects IPv6 capabilities
Summary: net-analyzer/bwping-1.7 - should not automagically detects IPv6 capabilities
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Markos Chandras (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-27 10:28 UTC by Sergey Popov
Modified: 2013-07-17 00:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Popov gentoo-dev 2013-01-27 10:28:18 UTC
When i build net-analyzer/bwping-1.7 on IPv6-enabled system i see this message during src_configure:

checking for IPv6 support... yes

and package builds with ipv6 support.

I think that such behaviour should be controlled with USE flag. Suggest patch for this:

--- bwping-1.7.ebuild   2013-01-27 14:21:42.000000000 +0400
+++ bwping-1.7-r1.ebuild        2013-01-27 14:21:42.000000000 +0400
@@ -13,9 +13,10 @@
 LICENSE="BSD"
 SLOT="0"
 KEYWORDS="~amd64 ~sparc ~x86 ~x86-fbsd"
-IUSE=""
+IUSE="ipv6"
 
 src_prepare() {
+       use ipv6 || export ac_cv_ipv6=no
        eautoreconf
 }


Also, i have blocked stabilization bug, cause ipv6 support did not present in previous stable version.
Comment 1 Agostino Sarubbo gentoo-dev 2013-01-30 18:50:54 UTC
not a blocker for the stabilization.
Comment 2 Mike Gilbert gentoo-dev 2013-07-16 19:21:34 UTC
Your solution does not account for the possibility that someone has kernel support for IPv6 disabled but also has USE=ipv6.
Comment 3 Sergey Popov gentoo-dev 2013-07-16 20:39:42 UTC
+  16 Jul 2013; Sergey Popov <pinkbyte@gentoo.org> +bwping-1.7-r1.ebuild,
+  +files/bwping-1.7-buildsystem-configurable-ipv6.patch:
+  Revision bump: migrate to autotools-utils eclass, support for ipv6 with
+  apropriate patch for buildsystem, wrt bug #454256

Also, i have sent patch to upstream developer
Comment 4 Mike Gilbert gentoo-dev 2013-07-16 20:53:08 UTC
Reopening since the patch still checks for kernel support at build time. I'll fix it when I have a chance.
Comment 5 Mike Gilbert gentoo-dev 2013-07-17 00:18:54 UTC
Eh, never mind. I don't care enough to make it right.