Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 453838 - app-admin/mcelog-1.0_pre3_p20120918: missing configuration file
Summary: app-admin/mcelog-1.0_pre3_p20120918: missing configuration file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Julian Ospald
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-01-24 14:06 UTC by Vincent Brillault
Modified: 2013-01-24 21:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Use mcelog internal building system (0001-Use-mcelog-internal-building-system.patch,1013 bytes, patch)
2013-01-24 14:06 UTC, Vincent Brillault
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Brillault 2013-01-24 14:06:30 UTC
Created attachment 336710 [details, diff]
Use mcelog internal building system

The upstream mcelog comes with a default configuration file for the mcelog daemon. The current ebuild uses a manual installation instead of using the upstream Makefile.

Here is a patch to use the internal make install instead, which results in the installation of the following files:
/etc/mcelog
/etc/mcelog/cache-error-trigger
/etc/mcelog/dimm-error-trigger
/etc/mcelog/mcelog.conf
/etc/mcelog/page-error-trigger
/etc/mcelog/socket-memory-error-trigger


I'm not sure that the default mcelog.conf is the most appropriate one as I'm not familiar with mcelog. In that case, shouldn't this configuration example at least be included in /usr/share ?
Comment 1 Julian Ospald 2013-01-24 14:49:13 UTC
I don't want to use the makefile

@ben is it ok to install them in /etc or should we rather go for /usr/share/doc/${PF}/examples?
Comment 2 Ben Kohler gentoo-dev 2013-01-24 19:40:27 UTC
The config & these triggers all look harmless/default enough to be installed "live" to /etc, IMHO.  Mostly just some extended logging for certain types of MCE events.

Maybe a line or 2 in einfo saying we're installing a new default config that may not 100% match built-in defaults?
Comment 3 Julian Ospald 2013-01-24 21:15:45 UTC
+*mcelog-1.0_pre3_p20120918-r1 (24 Jan 2013)
+
+  24 Jan 2013; Julian Ospald <hasufell@gentoo.org>
+  -mcelog-1.0_pre3_p20120918.ebuild, +mcelog-1.0_pre3_p20120918-r1.ebuild:
+  install default config files wrt #453838