Bug 453726 – sys-fs/udev-197-r4: no FILESDIR in pkg_*

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Fabio Erculiani (RETIRED) 2013-01-23 19:43:38 UTC]

The ebuild is toying with FILESDIR in pkg_* (pkg_postinst).
This is bad, and almost surely not permitted.
No FILESDIR in pkg_*, they break binpkgs and never works as expected.

Reproducible: Always

Steps to Reproduce:
1. open the ebuild
2. go to pkg_postinst
3. scream :-)

[Comment 1 Samuli Suominen (RETIRED) 2013-01-23 19:54:58 UTC]

(In reply to comment #0)
> The ebuild is toying with FILESDIR in pkg_* (pkg_postinst).
> This is bad, and almost surely not permitted.
> No FILESDIR in pkg_*, they break binpkgs and never works as expected.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. open the ebuild
> 2. go to pkg_postinst
> 3. scream :-)

Accessing ${T} is fine, no?

[Comment 2 Samuli Suominen (RETIRED) 2013-01-23 19:57:39 UTC]

If I copy the file from src_prepare to ${T}, I guess that doesn't help binary packages... meh

[Comment 3 Fabio Erculiani (RETIRED) 2013-01-23 19:58:44 UTC]

No, I don't think it's fine.
You should install it into somewhere on the system, like /usr or /etc and then reference it from pkg_*

[Comment 4 Julian Ospald 2013-01-23 20:19:22 UTC]

Is there a list/doc about common issues that break binpkgs? If not, we should probably put something together. Not every dev tests binpkgs.

[Comment 5 Samuli Suominen (RETIRED) 2013-01-23 20:24:07 UTC]

(In reply to comment #4)
> Is there a list/doc about common issues that break binpkgs? If not, we
> should probably put something together. Not every dev tests binpkgs.

nod

fixed in tree now:

http://sources.gentoo.org/viewvc.cgi/gentoo-x86/sys-fs/udev/udev-197-r4.ebuild?r1=1.15&r2=1.16

(same for -r3 and 9999)

[Comment 6 Samuli Suominen (RETIRED) 2013-01-23 20:25:29 UTC]

(In reply to comment #4)
> Is there a list/doc about common issues that break binpkgs? If not, we
> should probably put something together. Not every dev tests binpkgs.

sorry, I was responding to Comment #3, not Comment #4

I almost never use binpkgs myself so yeah

[Comment 7 Fabio Erculiani (RETIRED) 2013-01-23 21:45:01 UTC]

Awesome! thanks.