Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 453510 - x11-libs/pixman add configure flag and libpng dependency for tests
Summary: x11-libs/pixman add configure flag and libpng dependency for tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matt Turner
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-22 11:00 UTC by James Le Cuirot
Modified: 2013-01-31 07:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pixman-png.patch (pixman-png.patch,773 bytes, patch)
2013-01-22 11:00 UTC, James Le Cuirot
Details | Diff
pixman-png.patch (pixman-png.patch,789 bytes, patch)
2013-01-22 11:42 UTC, James Le Cuirot
Details | Diff
pixman-png.patch (pixman-png.patch,791 bytes, patch)
2013-01-22 11:48 UTC, James Le Cuirot
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Le Cuirot gentoo-dev 2013-01-22 11:00:59 UTC
Created attachment 336468 [details, diff]
pixman-png.patch

./configure has an --enable-libpng option and this hasn't been added to the ebuild. Please see the attached patch.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2013-01-22 11:36:50 UTC
Nah. It's only used by tests.

$ grep -r HAVE_LIBPNG * |grep -v Makefile.in
config.h.in:#undef HAVE_LIBPNG
configure:HAVE_LIBPNG
configure:$as_echo "#define HAVE_LIBPNG 1" >>confdefs.h
configure.ac:    AC_DEFINE([HAVE_LIBPNG], [1], [Whether we have libpng])
configure.ac:AC_SUBST(HAVE_LIBPNG)
test/utils.c:#ifdef HAVE_LIBPNG
test/utils.c:#ifdef HAVE_LIBPNG

As you can see, it's only used for tests -- maybe the maintainers want test? ( media-libs/libpng:0 ) and $(use_enable test libpng)
Comment 2 James Le Cuirot gentoo-dev 2013-01-22 11:42:21 UTC
Created attachment 336470 [details, diff]
pixman-png.patch

Okay, we at least need what you suggest or --disable-libpng because this broke my cross-compile. Here's a new patch.
Comment 3 James Le Cuirot gentoo-dev 2013-01-22 11:48:04 UTC
Created attachment 336472 [details, diff]
pixman-png.patch

Oops, missed the SLOT. I realise its importance here.
Comment 4 Rafał Mużyło 2013-01-22 11:51:01 UTC
There's no real point for this.
In 0.28 libpng is used only in a single function of a *test* program, that doesn't seem to be called anyway. What's more, the function seems useful for interactive tests only.
Comment 5 James Le Cuirot gentoo-dev 2013-01-22 12:01:47 UTC
Okay, but we should as least add --disable-libpng because it still tries to build the test and fails if libpng is in / but not in ${ROOT}.
Comment 6 Matt Turner gentoo-dev 2013-01-31 05:52:17 UTC
Done. Thanks.