Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 452458 - =media-plugins/audacious-plugins-3.3.3 is not compatible with dev-libs/libcdio-paranoia
Summary: =media-plugins/audacious-plugins-3.3.3 is not compatible with dev-libs/libcdi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jeff (JD) Horelick (RETIRED)
URL:
Whiteboard:
Keywords:
: 452666 452706 472134 498788 499114 499210 (view as bug list)
Depends on:
Blocks: 452430
  Show dependency tree
 
Reported: 2013-01-16 09:33 UTC by Samuli Suominen (RETIRED)
Modified: 2014-01-29 06:29 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log after fixes from Comment #0 (build.log,36.21 KB, text/plain)
2013-01-16 09:33 UTC, Samuli Suominen (RETIRED)
Details
patch rejects on audacious-plugins-3.2.4 (cdaudio-ng.c.rej,2.00 KB, patch)
2014-01-24 17:04 UTC, igel
Details | Diff
modifed patch for audacious-plugins-3.2.4 to work with libcdio-0.90 (audacious-plugins-3.2.4.patch,4.20 KB, patch)
2014-01-24 17:26 UTC, igel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2013-01-16 09:33:55 UTC
Created attachment 335792 [details]
build.log after fixes from Comment #0

dep should be:

|| ( dev-libs/libcdio-paranoia <dev-libs/libcdio-0.90[-minimal] )

this will get you to the actual errors:

if has_version dev-libs/libcdio-paranoia; then
sed -i -e 's:cdio/cdda.h:cdio/paranoia/cdda.h:' src/cdaudio-ng/cdaudio-ng.c || die
fi
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2013-01-16 10:04:00 UTC
found this, you might find it useful:

https://projects.archlinux.org/svntogit/packages.git/tree/trunk/libcdio.patch?h=packages/audacious-plugins
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2013-01-16 16:43:33 UTC
Applied to tree
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2013-01-17 14:13:08 UTC
*** Bug 452666 has been marked as a duplicate of this bug. ***
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2013-01-17 18:41:09 UTC
*** Bug 452706 has been marked as a duplicate of this bug. ***
Comment 5 Attila Stehr 2013-01-20 14:13:01 UTC
perfect, thanks!
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2014-01-21 07:46:57 UTC
*** Bug 472134 has been marked as a duplicate of this bug. ***
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2014-01-21 16:30:00 UTC
*** Bug 498788 has been marked as a duplicate of this bug. ***
Comment 8 Evert 2014-01-21 16:46:16 UTC
Thanks, 3.4.1 seems to work OK :)

>>> Emerging (1 of 2) media-sound/audacious-3.4.1
>>> Installing (1 of 2) media-sound/audacious-3.4.1
>>> Emerging (2 of 2) media-plugins/audacious-plugins-3.4.1
>>> Installing (2 of 2) media-plugins/audacious-plugins-3.4.1
Comment 9 igel 2014-01-24 13:48:07 UTC
erm, so, this still breaks in <media-plugins/audacious-plugins-3.3 so if, for whatever reason (like me, not wanting gtk-3 on my system, which >=media-plugins/audacious-plugins-3.3 depends on), someone wants to install a version prior to 3.3, they are still facing the compile error. I wouldn't expect that from a package that is marked stable in the portage tree, no matter if there are newer versions...
Comment 10 Samuli Suominen (RETIRED) gentoo-dev 2014-01-24 13:52:02 UTC
(In reply to igel from comment #9)
> erm, so, this still breaks in <media-plugins/audacious-plugins-3.3 so if,
> for whatever reason (like me, not wanting gtk-3 on my system, which
> >=media-plugins/audacious-plugins-3.3 depends on), someone wants to install
> a version prior to 3.3, they are still facing the compile error. I wouldn't
> expect that from a package that is marked stable in the portage tree, no
> matter if there are newer versions...

try applying the audacious-plugins-3.3.3-libcdio.patch in older version. it might apply cleanly. report back here for others to benefit. ;)

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-plugins/audacious-plugins/files/audacious-plugins-3.3.3-libcdio.patch?view=log
Comment 11 Samuli Suominen (RETIRED) gentoo-dev 2014-01-24 13:53:07 UTC
stabilization is supposed to be happening at bug 490463, but the maintainer didn't add arches to CC list yet...
Comment 12 Jeroen Roovers (RETIRED) gentoo-dev 2014-01-24 16:44:07 UTC
*** Bug 499114 has been marked as a duplicate of this bug. ***
Comment 13 igel 2014-01-24 17:04:11 UTC
Created attachment 368628 [details, diff]
patch rejects on audacious-plugins-3.2.4
Comment 14 igel 2014-01-24 17:26:04 UTC
Created attachment 368634 [details, diff]
modifed patch for audacious-plugins-3.2.4 to work with libcdio-0.90

So, this one works for me (I haven't tested any other useflags that what I've set on my system) with both libcdio-0.90 and below.
Comment 15 Evert 2014-01-24 17:38:59 UTC
Great! But how long should a new revision (with a new patch) go in unstable before it goes stable? Isn't 3.4.1 at that time already stable? In other words, does it make sense to introduce a new revision for 3.2.4 at all?
Comment 16 igel 2014-01-24 19:50:55 UTC
(In reply to Evert from comment #15)
> Great! But how long should a new revision (with a new patch) go in unstable
> before it goes stable? Isn't 3.4.1 at that time already stable? In other
> words, does it make sense to introduce a new revision for 3.2.4 at all?

Equivalently, you could ask if it makes sense to keep gtk-2 around, while gtk-3 is stable...
Comment 17 Alex Xu (Hello71) 2014-01-25 13:54:56 UTC
*** Bug 499210 has been marked as a duplicate of this bug. ***
Comment 18 Samuli Suominen (RETIRED) gentoo-dev 2014-01-29 06:29:33 UTC
*** Bug 498788 has been marked as a duplicate of this bug. ***