Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 451268 - media-libs/opus: --enable-custom-modes is discouraged
Summary: media-libs/opus: --enable-custom-modes is discouraged
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-10 18:28 UTC by Hanno Böck
Modified: 2013-01-21 08:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hanno Böck gentoo-dev 2013-01-10 18:28:53 UTC
The opus ebuild passes --enable-custom-modes to configure. This is rarely needed and generally discouraged by the opus devs. I don't think anything in portage makes use of it. opus devs told me on irc that it shoudln't cause problems, but it may cause performance hits in certain situations.
I'd propose disabling it or at least only enable it via a local useflag. (but as long as there's no use for it, probably disabling is the better choice)
Comment 1 Hanno Böck gentoo-dev 2013-01-12 13:08:37 UTC
done
Comment 2 Nikos Chantziaras 2013-01-21 08:19:38 UTC
Nothing in portage needs it, but some software out there does need it. I need to build JACK2 here, and it fails:

../common/JackNetTool.h:412:30: fatal error: opus/opus_custom.h: No such file or directory

A USE flag would be nice. After all, it *is* an option from upstream.