Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 450520 - Update media-sound/spotify to 0.8.8.323
Summary: Update media-sound/spotify to 0.8.8.323
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthew Thode ( prometheanfire )
URL: http://community.spotify.com/t5/Deskt...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-06 12:07 UTC by Uwe L. Korn
Modified: 2013-01-11 08:17 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for spotify-0.8.8.323 (spotify-0.8.8.323.ebuild,3.75 KB, application/octet-stream)
2013-01-06 12:08 UTC, Uwe L. Korn
Details
ebuild for spotify-0.8.8.323 (with correct PaX paths) (spotify-0.8.8.323-r1.ebuild,3.79 KB, application/octet-stream)
2013-01-06 15:55 UTC, Uwe L. Korn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe L. Korn 2013-01-06 12:07:00 UTC
Update the ebuild to the lastest Spotify version supporting the new disovery features.

Reproducible: Always
Comment 1 Uwe L. Korn 2013-01-06 12:08:11 UTC
Created attachment 334644 [details]
ebuild for spotify-0.8.8.323

Taken from my overlay https://github.com/xhochy/gentoo-overlay as described in http://xhochy.github.com/2013/01/06/spotify-0.8.8-gentoo/
Comment 2 Graham Murray 2013-01-06 15:35:06 UTC
One slight problem with the ebuild. USE=pax_kernel, the file it is adding PAX marks is set to "${ED}"/opt/${PN}/${PN}. This does not exist and should be "${ED}"/opt/${PN}/spotify-client/${PN}
Comment 3 Uwe L. Korn 2013-01-06 15:55:03 UTC
Created attachment 334664 [details]
ebuild for spotify-0.8.8.323 (with correct PaX paths)
Comment 4 Uwe L. Korn 2013-01-06 15:55:39 UTC
Fix the PaX Problem with the latest ebuild.
Comment 5 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-01-08 04:10:42 UTC
fixed in tree
Comment 6 Ortwin Glueck 2013-01-09 13:37:17 UTC
regression: missing start menu entry (KDE). 

because pkg_postinst() fails:
>>> Installing (1 of 1) media-sound/spotify-0.8.8.323
xdg-icon-resource: size argument must be numeric
Try 'xdg-icon-resource --help' for more information.
xdg-desktop-menu: file 'spotify.desktop' does not exist


I suggest to use the eutils eclass and use newicon domenu functions instead of those horrible (un)register.sh scripts from Spotify.
Comment 7 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-01-09 14:42:04 UTC
r1 in tree, please test
Comment 8 jannis 2013-01-09 17:06:42 UTC
(In reply to comment #7)
> r1 in tree, please test

fails here:
>>> Install spotify-0.8.8.323-r1 into /var/tmp/portage/media-sound/spotify-0.8.8.323-r1/image/ category media-sound
 * 512 is an unsupported icon size!
 * ERROR: media-sound/spotify-0.8.8.323-r1 failed (install phase):
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line   93:  Called src_install
 *   environment, line 2193:  Called doicon '-s' '512' '/opt/spotify/spotify-client/Icons/spotify-linux-512.png'
 *   environment, line  476:  Called _iconins 'doicon' '-s' '512' '/opt/spotify/spotify-client/Icons/spotify-linux-512.png'
 *   environment, line  359:  Called die
 * The specific snippet of code:
 *       fi ) || die
Comment 9 Ortwin Glueck 2013-01-09 17:21:38 UTC
You should do it like so (ignore the 512 icon, it's not supported by xdg):
        for size in 16 22 24 32 48 64 128 256; do
                newicon -s ${size} opt/spotify/spotify-client/Icons/spotify-linux-${size}.png spotify-client.png
        done
        domenu opt/spotify/spotify-client/spotify.desktop

Mind the use of *newicon* which renames the icon to spotify-client, since that's what is used in the desktop file. And put domenu after newicon, otherwise I am not sure if xdg will install it if it doesn't find the right icon!
Comment 10 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-01-09 18:29:32 UTC
In tree as r1 still (since it would fail with the 512, could have sworn that was valid, ah well).

Also, changed the order.  While it should have worked I think (since the newicon/doicon and domenu are in the install phase), it's good practice.
Comment 11 Ortwin Glueck 2013-01-10 06:57:25 UTC
>>> Install spotify-0.8.8.323-r1 into /var/tmp/portage/media-sound/spotify-0.8.8.323-r1/image/ category media-sound
 * ERROR: media-sound/spotify-0.8.8.323-r1 failed (install phase):
 *   !!! newins: /opt/spotify/spotify-client/Icons/spotify-linux-16.png does not exist


You can't use SPOTIFY_HOME: it's the final location in the merged system, not the one during the ebuild!

Oh and please run these very simple tests yourself. It's no rocket science to run emerge, is it.
Comment 12 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-01-10 07:08:48 UTC
already fixed, ${S}${SPOTIFY_HOME} works
Comment 13 Ortwin Glueck 2013-01-10 10:23:31 UTC
You need to add it also to the domenu command...
Comment 14 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-01-10 17:11:55 UTC
I don't know why when I test it's happy (I remove and verify removal of /opt/spotify stuff).  But updated again.
Comment 15 Ortwin Glueck 2013-01-10 17:34:26 UTC
Because you already have spotify installed, so /opt/spotify is a valida path...

If you emerge -C spotify and emerge -1 spotify again, it will fail tho.
Comment 16 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-01-10 17:42:28 UTC
I did not have it installed when I tested.  Anyway, it's been fixed, read the previous comment I made.
Comment 17 Ortwin Glueck 2013-01-11 08:17:36 UTC
Awsome, works fine now. Thanks a lot.