Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 450332 - Add cdio or cdparanoia use flag to gst-plugins-meta
Summary: Add cdio or cdparanoia use flag to gst-plugins-meta
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-05 05:06 UTC by Tim Climis
Modified: 2013-01-07 02:12 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Climis 2013-01-05 05:06:35 UTC
I just spent a few hours trying to figure out why I couldn't play CD's (even though cdda is enabled as a USE flag in my profile) and it turned out that gstreamer didn't include a plug-in for CD playback.  

When I looked at the gst-plugins-meta package, there wasn't a USE flag to enable CD playback either, even though at least two plugins for that exist: cdparanoia and cdio.  I suggest adding USE flags for both, and if the cdda USE flag is enabled, auto-selecting a default.

Having CD audio enabled in the profile, but then not including CD playback as a result is non-intuitive behavior at best.

Reproducible: Always
Comment 1 Matěj Laitl 2013-01-06 11:45:23 UTC
(In reply to comment #0)
> I just spent a few hours trying to figure out why I couldn't play CD's (even
> though cdda is enabled as a USE flag in my profile) and it turned out that
> gstreamer didn't include a plug-in for CD playback.  

I got hit by the same problem trying to debug why Amarok (which I'm a developer of) doesn't play audio CDs.

Additionally, Amarok ebuild has cdda USE-flag, which sadly currently doesn't ensure working CD playback. If gst-plugins-meta had cdda USE-flag, then phonon-gstreamer and phonon could have it and Amarok could depend on it.
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2013-01-06 22:48:48 UTC
Sorryn but meta ebuild is not here to provide plugins required for applications to provide basic features. It is only here to hold extra stuff. ebuilds should provide direct dependencies on plugins that are required for them to work, see totem, sound-juicer and rhythmbox for example.
Comment 3 Matěj Laitl 2013-01-06 22:57:34 UTC
(In reply to comment #2)
> Sorryn but meta ebuild is not here to provide plugins required for
> applications to provide basic features. It is only here to hold extra stuff.
> ebuilds should provide direct dependencies on plugins that are required for
> them to work, see totem, sound-juicer and rhythmbox for example.

Gilles, even if this reason is invalid, original Tim's one still holds:

It is very strange that you don't get Audio CD reading support when emerging gst-plugins-meta package with cdda, cdparanoia and cdio in USE. What is a difference between cdda flag (not handled by gst-plugins-meta) and e.g. a dvd flag, which is handled correctly?
Comment 4 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-01-06 23:18:48 UTC
(In reply to comment #2)
> Sorryn but meta ebuild is not here to provide plugins required for
> applications to provide basic features. It is only here to hold extra stuff.
> ebuilds should provide direct dependencies on plugins that are required for
> them to work, see totem, sound-juicer and rhythmbox for example.

IMHO the meta ebuild is here not for ebuilds to depend on, but for *users*. Users who have no idea that they need gst-plugins-cdparanoia to play audio CDs, or that installing gst-plugins-assrender is equivalent to USE=libass in all normal Gentoo video-related ebuilds.
Comment 5 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-01-06 23:40:30 UTC
I have added a "cdda" USE flag, which pulls in || ( gst-plugins-cdparanoia gst-plugins-cdio ). Packages that require CD audio for their core functionality (e.g. sound-juicer) certainly need to depend on these plugins directly; but for users of generic media players (e.g. totem) that can play audio CDs among >9000 other potential media sources, it's highly convenient to have a "cdda" flag in the meta ebuild.

+*gst-plugins-meta-1.0-r1 (06 Jan 2013)
+*gst-plugins-meta-0.10-r8 (06 Jan 2013)
+
+  06 Jan 2013; Alexandre Rostovtsev <tetromino@gentoo.org>
+  +gst-plugins-meta-0.10-r8.ebuild, +gst-plugins-meta-1.0-r1.ebuild,
+  metadata.xml:
+  Add cdda, jack, libass, opus, x264, xvid USE flags that users have been
+  requesting (bugs #412183, #422637, #442566, #450332). Drop alpha, arm, hppa,
+  ia64, ppc, ppc64, sparc, amd64-fbsd keywords due to new dependencies.
Comment 6 Matěj Laitl 2013-01-06 23:43:16 UTC
(In reply to comment #5)
> I have added a "cdda" USE flag, which pulls in || ( gst-plugins-cdparanoia
> gst-plugins-cdio ). Packages that require CD audio for their core
> functionality (e.g. sound-juicer) certainly need to depend on these plugins
> directly; but for users of generic media players (e.g. totem) that can play
> audio CDs among >9000 other potential media sources, it's highly convenient
> to have a "cdda" flag in the meta ebuild.

That was quick, thanks!
Comment 7 Tim Climis 2013-01-07 02:12:20 UTC
(In reply to comment #6)
> That was quick, thanks!

Ditto!