Bug 448538 – net-misc/gns3-0.8.3.1 version bump request

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Aaron Bauman (RETIRED) 2012-12-25 15:29:18 UTC]

Created attachment 333298 [details]
ebuild

Please bump version to 0.8.3.1

[Comment 1 Aaron Bauman (RETIRED) 2012-12-25 15:30:35 UTC]

Created attachment 333300 [details, diff]
install path patch

changes the default wrapper_dir in setup.py to remove the illegal install to /usr/local

[Comment 2 Jeroen Roovers (RETIRED) 2012-12-25 16:03:13 UTC]

Comment on attachment 333298 [details]
ebuild

--- gns3-0.8.2.ebuild   2012-05-10 23:35:07.000000000 +0200
+++ -   2012-12-25 17:02:59.832177649 +0100
@@ -1,6 +1,6 @@
 # Copyright 1999-2012 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/net-misc/gns3/gns3-0.8.2.ebuild,v 1.1 2012/05/10 21:35:07 hwoarang Exp $
+# $Header: /var/cvsroot/gentoo-x86/net-misc/gns3/gns3-0.8.3.1.ebuild,v 1.1 2012/05/10 21:35:07 bman Exp $
 
 EAPI="3"

[Comment 3 Aaron Bauman (RETIRED) 2012-12-25 16:37:25 UTC]

Created attachment 333306 [details]
latest ebuild changes

changes based on developer feedback.  EAPI changed to 4 and || dies removed.  virtualbox/virtualbox-bin IUSE added for users wishing to configure virtualbox support.

[Comment 4 Aaron Bauman (RETIRED) 2012-12-25 16:38:06 UTC]

Created attachment 333308 [details]
install path patch

[Comment 5 Aaron Bauman (RETIRED) 2012-12-25 16:45:29 UTC]

Created attachment 333312 [details]
latest ebuild changes

qemu use flag added for those wishing to configure it themselves.

[Comment 6 Aaron Bauman (RETIRED) 2012-12-25 17:08:44 UTC]

Created attachment 333318 [details]
latest ebuild changes

added putty use flag for those wishing to use putty

[Comment 7 Aaron Bauman (RETIRED) 2012-12-25 18:00:16 UTC]

Created attachment 333326 [details]
latest ebuild changes

Should be final use flag addition.  Added telnet for those wishing to integrate with KDE/Gnome terminal and require it.

[Comment 8 Aaron Bauman (RETIRED) 2013-01-01 15:17:37 UTC]

Created attachment 333948 [details]
ebuild

[Comment 9 Aaron Bauman (RETIRED) 2013-01-02 17:25:04 UTC]

Created attachment 334062 [details]
metadata.xml

[Comment 10 Aaron Bauman (RETIRED) 2013-01-03 07:47:02 UTC]

Created attachment 334142 [details]
ebuild

[Comment 11 Markos Chandras (RETIRED) 2013-01-16 19:32:02 UTC]

The ebuild is not good

  dependency.bad                10
   net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND: ~x86(default/linux/x86/10.0) ['>=app-emulation/qemu-1.2.1']
   net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND: ~x86(default/linux/x86/10.0/desktop) ['>=app-emulation/qemu-1.2.1']
   net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND: ~x86(default/linux/x86/10.0/desktop/gnome) ['>=app-emulation/qemu-1.2.1']
   net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND: ~x86(default/linux/x86/10.0/desktop/kde) ['>=app-emulation/qemu-1.2.1']
   net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND: ~x86(default/linux/x86/10.0/developer) ['>=app-emulation/qemu-1.2.1']
   net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND: ~x86(default/linux/x86/10.0/server) ['>=app-emulation/qemu-1.2.1']
   net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND: ~amd64(hardened/linux/amd64/no-multilib) ['>=app-emulation/virtualbox-4.1.22']
   net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND: ~amd64(hardened/linux/amd64/no-multilib/selinux) ['>=app-emulation/virtualbox-4.1.22']
   net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND: ~x86(hardened/linux/x86) ['>=app-emulation/qemu-1.2.1']
   net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND: ~x86(hardened/linux/x86/selinux) ['>=app-emulation/qemu-1.2.1']

This is because qemu is masked on x86 (see profiles/arch/x86/package.mask) and virtualbox is not available on amd64/no-multilib

The virtualbox and qemu flags need to be masked on x86 and amd64/no-multilib or always be disabled.

Please run, "repoman full" in order to spot this problems before submitting an ebuild

Opinions?

[Comment 12 Markos Chandras (RETIRED) 2013-01-16 19:44:45 UTC]

(In reply to comment #11)
> The ebuild is not good
> 
>   dependency.bad                10
>    net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND: ~x86(default/linux/x86/10.0)
> ['>=app-emulation/qemu-1.2.1']
>    net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND:
> ~x86(default/linux/x86/10.0/desktop) ['>=app-emulation/qemu-1.2.1']
>    net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND:
> ~x86(default/linux/x86/10.0/desktop/gnome) ['>=app-emulation/qemu-1.2.1']
>    net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND:
> ~x86(default/linux/x86/10.0/desktop/kde) ['>=app-emulation/qemu-1.2.1']
>    net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND:
> ~x86(default/linux/x86/10.0/developer) ['>=app-emulation/qemu-1.2.1']
>    net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND:
> ~x86(default/linux/x86/10.0/server) ['>=app-emulation/qemu-1.2.1']
>    net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND:
> ~amd64(hardened/linux/amd64/no-multilib)
> ['>=app-emulation/virtualbox-4.1.22']
>    net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND:
> ~amd64(hardened/linux/amd64/no-multilib/selinux)
> ['>=app-emulation/virtualbox-4.1.22']
>    net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND: ~x86(hardened/linux/x86)
> ['>=app-emulation/qemu-1.2.1']
>    net-misc/gns3/gns3-0.8.3.1.ebuild: RDEPEND:
> ~x86(hardened/linux/x86/selinux) ['>=app-emulation/qemu-1.2.1']
> 
> This is because qemu is masked on x86 (see profiles/arch/x86/package.mask)
> and virtualbox is not available on amd64/no-multilib
> 
> The virtualbox and qemu flags need to be masked on x86 and amd64/no-multilib
> or always be disabled.
> 
> Please run, "repoman full" in order to spot this problems before submitting
> an ebuild
> 
> Opinions?

Now that I see it, the ebuild is wrong. You should not have use flags for runtime dependencies because if one changes, you need to rebuild the package for absolutely zero benefit. It is better if you just add an elog message in pkg_postinst function, saying that the following *optional* packages can be used along with the gns3 package. So all use flags need to go away

[Comment 13 Markos Chandras (RETIRED) 2013-01-18 09:09:41 UTC]

*** Bug 435724 has been marked as a duplicate of this bug. ***

[Comment 14 Aaron Bauman (RETIRED) 2013-01-26 13:07:58 UTC]

Created attachment 336892 [details]
new ebuild

updated ebuild per Markos comments.

[Comment 15 Aaron Bauman (RETIRED) 2013-01-26 13:08:34 UTC]

Created attachment 336894 [details]
updated metadata removing dependencies per Markos comments

updated metadata removing dependencies per Markos comments

[Comment 16 Markos Chandras (RETIRED) 2013-01-26 18:04:52 UTC]

+*gns3-0.8.3.1 (26 Jan 2013)
+
+  26 Jan 2013; Markos Chandras <[e-mail]>
+  +files/gns3-0.8.3.1_install_path.patch, +gns3-0.8.3.1.ebuild, metadata.xml:
+  Version bump. Bug #448538. Thanks to Aaron Bauman <[e-mail]> who
+  will maintain it
+