Bug 448436 – net-misc/openconnect: non-standard gnutls USE flag handling

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2012-12-24 16:48:55 UTC]

@proxy-maint: fix your metadata which is in the wrong order, please.

This ebuild is using the gnutls flag in a non-standard way. The usual way this is handled is:

ssl? ( !gnutls? ( openssl ) gnutls? ( gnutls ) )

but in this case you got openssl and gnutls USE flag, and there is no description on why this should be special.

So please fix this.

[Comment 1 Markos Chandras (RETIRED) 2012-12-24 16:57:01 UTC]

So I guess you are suggesting to rename openssl to ssl and migrate to EAPI5 to use REQUIRED_USE correct?

[Comment 2 Diego Elio Pettenò (RETIRED) 2012-12-24 17:01:33 UTC]

It's already using REQUIRED_USE (incorrectly).

My suggestion is to rename openssl to ssl, drop the REQUIRED_USE, if ssl is optional, and if it's not, drop the openssl USE flag entirely, and if gnutls is not enabled, default to openssl.

[Comment 3 Diego Elio Pettenò (RETIRED) 2012-12-24 17:01:50 UTC]

(In which case the only conditions you'd get would be !gnutls and gnutls).

[Comment 4 Markos Chandras (RETIRED) 2012-12-24 17:06:44 UTC]

Ok thanks for the feedback

[Comment 5 Matthew Schultz 2012-12-25 06:36:50 UTC]

Created attachment 333240 [details]
openconnect-4.07-r3.ebuild

-Rearranged use flags to use ssl and a check on gnutls.
-Added support for conditionally building and installing docs.

[Comment 6 Matthew Schultz 2012-12-25 06:37:02 UTC]

Created attachment 333242 [details]
metadata.xml

[Comment 7 Diego Elio Pettenò (RETIRED) 2012-12-25 09:17:11 UTC]

Almost but not yet. As I said, if it's not optional to have at least one of OpenSSL or GnuTLS (which seems to me to be the case), you should drop the ssl USE flag entirely and just rely on !gnutls to enable openssl support.

This also means dropping the REQUIRED_USE whole.

[Comment 8 Markos Chandras (RETIRED) 2012-12-25 10:23:38 UTC]

(In reply to comment #6)
> Created attachment 333242 [details]
> metadata.xml

ssl is a global use flags. I see no reason to re-describe it in metadata.xml

[Comment 9 Matthew Schultz 2012-12-25 16:27:22 UTC]

Created attachment 333302 [details]
openconnect-4.07-r3.ebuild

Removed required_use in favor of controlling ssl usage strictly through gnutls flag.

[Comment 10 Matthew Schultz 2012-12-25 16:27:50 UTC]

Created attachment 333304 [details]
metadata.xml

Removed ssl use flag description.

[Comment 11 Matthew Schultz 2013-01-02 03:33:10 UTC]

@proxy-maint: Please commit my latest ebuild if there are no longer any issues with it.  Also remove 3.11 from the tree due to the security issue with it.

[Comment 12 Markos Chandras (RETIRED) 2013-01-04 22:18:44 UTC]

It's not possible to commit the new metadata.xml because it's required for existing ebuild. I will clean it up in the future

[Comment 13 Markos Chandras (RETIRED) 2013-01-04 22:20:26 UTC]

+*openconnect-4.07-r3 (04 Jan 2013)
+
+  04 Jan 2013; Markos Chandras <[e-mail]>
+  +openconnect-4.07-r3.ebuild:
+  rework gnutls, ssl use flags logic. Bug #448436. Thanks to Matthew Schultz
+  <[e-mail]>
+