Created attachment 333184 [details, diff] conky-1.9.0-update-when-message-count-decreases.patch Hi, i used the hollidays to play around with the conky imap command. First thing i noticed was that i got no changes with imap_unseen command either when i read or delete a mail. After checking that my arguments where ok i looked at the code. Well, what a mess.... :D in my eyes this needs to be totally rewritten. And it seems that the conky authors came to the same point because in current trunk the mail.c is replaced by a totally new mail.cc. The mail.c is so messed up that i soon stopped trying to fix the issue but i still wanted this to work and tried a workaround that is not very nice but works for me. I changed the condition that mades updates occur and forced conky to update on any event that occures in IDLE mode. My imap server (dovecot) accepts this but always complains that my client is broken because i trigger a STATUS command on a folder i have already SELECTed. OK, this was the same with the old code and now it seems to work at least. As the current conky trunk is to be completely rewritten, at least regarding the mail handling i send my patch for 1.9.0 to you. Can you please review it an consider adding it to the ebuild. Thank you and merry christmas Georg Hopp
Hi, changes in the source code should be reported to the upstream developers http://conky.sourceforge.net/
(In reply to comment #1) > Hi, > > changes in the source code should be reported to the upstream developers > > http://conky.sourceforge.net/ metadata.xml says otherwise.
I can not test this as I do not use the imap functionality. This patch should go upstream, preferably as well for the rewritten new version.
OK, i will send the patch upstream and ask if it is still relevant for the new version. I guess it's not.
OK, the patch is merge on the official conky 1.9.0 github branch. https://github.com/brndnmtthws/conky/blob/1.9.0/src/mail.c anything else i can do?
(In reply to comment #5) > OK, the patch is merge on the official conky 1.9.0 github branch. > > https://github.com/brndnmtthws/conky/blob/1.9.0/src/mail.c > > anything else i can do? There is a 1.9.1 branch with more recent commits. I guess it should go there.
+*conky-1.9.0-r2 (11 Jan 2013) + + 11 Jan 2013; Daniel Pielmeier <billie@gentoo.org> +conky-1.9.0-r2.ebuild: + Fix bug #448366. Thanks to Georg Hopp for the patch. Should be fixed now. I have created the patch from the commit to the 1.9.1 branch. If anything went wrong please re-open the bug and report here.
