448118 – sci-chemistry/openbabel-python: improvements of python-r1 use

Bug 448118 - sci-chemistry/openbabel-python: improvements of python-r1 use

Summary: sci-chemistry/openbabel-python: improvements of python-r1 use

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal enhancement (vote)
Assignee:	Justin Lecher (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-12-21 21:39 UTC by Michał Górny
Modified:	2012-12-23 11:33 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
The diff to the ebuild (openbabel-python.diff,1.28 KB, patch) 2012-12-21 21:39 UTC, Michał Górny	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2012-12-21 21:39:56 UTC

Created attachment 332976 [details, diff]
The diff to the ebuild

1) cmake-utils is BUILD_DIR-aware, there's no need to map it to CMAKE_BUILD_DIR,

2) the ebuild should call 'python_optimize' in my_impl_src_install() to compile the installed modules,

3) missing || die in 'cd'.

I'm attaching a diff for the ebuild.

Comment 1 Justin Lecher (RETIRED) gentoo-dev

2012-12-23 11:33:51 UTC

Thanks for the patch, applied.

+  23 Dec 2012; Justin Lecher <jlec@gentoo.org> openbabel-python-2.3.2.ebuild,
+  metadata.xml:
+  Add proposed enhancements by mgorny, #448118
+