Bug 44809 – scummvm-0.6.0.ebuild (update)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Stephan Schiffel 2004-03-15 23:13:31 UTC]

Hi!

ScummVM 0.6.0, the famous interpreter for SCUMM-games and some others, was released today. Here is an ebuild for it, which has also some other improvements:
I don't know the policy for new USE_EXPANDs, but I have added one:
ENGINES - contains the engines to be built (if empty or undefined all engines get installed), possible values are described in the ebuild

If that is not a good solution then it could also be done by local useflags.

other changes:
- now uses the "flac" use flag and has media-libs/flac as dependency
- changed dependencies to state minimal versions (found in the configure script)
- now uses the "debug" use flag



Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Stephan Schiffel 2004-03-15 23:15:24 UTC]

Created attachment 27439 [details]
ebuild

[Comment 2 Mr. Bones. (RETIRED) 2004-03-15 23:47:06 UTC]

Where do you see that configure supports flac?

[Comment 3 Stephan Schiffel 2004-03-15 23:55:24 UTC]

Sorry, my fault. It was in the daily snapshot yesterday, but obviously it has not made it in the release.

[Comment 4 Stephan Schiffel 2004-03-15 23:57:07 UTC]

Created attachment 27442 [details]
ebuild

removed "flac" use flag from ebuild

[Comment 5 Spider (RETIRED) 2004-03-15 23:57:25 UTC]

a hint would be to use "use_enable " for those things instead of the if-statements

confstr="`use_enable flac` `use_enable zlib` `use_enable debug` `use_enable mad` `use_enable oggvorbis vorbis`"

[Comment 6 Stephan Schiffel 2004-03-16 00:24:59 UTC]

Created attachment 27446 [details]
improved ebuild

I made use of "use_enable" as Spider proposed.

What about the USE_EXPAND, is this ok?

[Comment 7 Mr. Bones. (RETIRED) 2004-03-16 00:43:32 UTC]

I think all the engines should just be built-in.  If scummvm had broader
application, it would make sense to make the configuration more fine-grained.
It's not going to change the size of the executable by much to just
put all the engines in.  If there's a big demand for it later we can revisit
it.

[Comment 8 Stephan Schiffel 2004-03-16 01:00:53 UTC]

Created attachment 27448 [details]
improved ebuild

removed the USE_EXPAND and changed the test of "debug" use flag back to old
"if" solution because there is no "--enable-debug" option.

[Comment 9 Spider (RETIRED) 2004-03-16 01:13:30 UTC]

btw... the use of src_unpack here is redundant. You just duplicate defaults there.

(oops, missed that in my first lookover)

[Comment 10 Stephan Schiffel 2004-03-16 01:18:18 UTC]

Created attachment 27449 [details]
ebuild

redundant src_unpack removed

[Comment 11 Mr. Bones. (RETIRED) 2004-03-16 01:56:03 UTC]

Bumped the version in CVS.  Thanks for the bug report and ebuild.

[Comment 12 Boris 2004-03-16 05:11:43 UTC]

A small addition:
According to the README [1] libmpeg2 in version 0.4 or later is preferable for scummvm. So when libmpeg2-0.4.0 bumps to stable, the depend could be set to this.

[1] http://cvs.sourceforge.net/viewcvs.py/scummvm/scummvm/README?rev=release-0-6-0