Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 447604 - net-im/turses missing RDEPEND, unused DEPENDs and incorrect python depends
Summary: net-im/turses missing RDEPEND, unused DEPENDs and incorrect python depends
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Pavlos Ratis (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-12-17 15:16 UTC by James Rowe
Modified: 2013-05-09 23:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
turses-0.2.9-fix_depends.patch (turses-0.2.9-fix_depends.patch,725 bytes, patch)
2012-12-17 15:17 UTC, James Rowe
Details | Diff
turses_global_tests.patch (turses_global_tests.patch,463 bytes, patch)
2012-12-20 11:33 UTC, James Rowe
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Rowe 2012-12-17 15:16:34 UTC
RDEPEND is unset, while it should contain the majority of DEPEND.

The tests are only run against the current Python interpreter, defining
DISTUTILS_SRC_TEST=nosetests is likely the right way to go for this.

tox is in DEPEND's USE=test conditional, but it isn't used in the current
ebuild.  If it was to be used in the future then the tox config's dependencies
on 2.6, 2.7 and pypy should probably be handled too.  Setting DISTUTILS_SRC_TEST
accomplishes basically the same thing as tox support would in this instance
anyway.

turses makes use of context handlers(2.6+ or __future__ import) and
except..as syntax(2.6+).  It isn't difficult to patch for 2.5 support if
required, but it is probably simpler to just ignore it ;)

The attached patch addresses these points.

Thanks,

James

PS. Can I sneak in a small bump request too?  0.2.10 was released a few days
ago.


Reproducible: Always
Comment 1 James Rowe 2012-12-17 15:17:01 UTC
Created attachment 332580 [details, diff]
turses-0.2.9-fix_depends.patch
Comment 2 James Rowe 2012-12-20 11:33:46 UTC
Created attachment 332780 [details, diff]
turses_global_tests.patch

I hadn't spotted it originally, but turses also installs a top-level tests directory.  This weak patch fixes that.
Comment 3 Pavlos Ratis (RETIRED) Gentoo Infrastructure gentoo-dev 2013-02-17 10:43:22 UTC
turses bumped to 0.2.11. Everything that you mention has been fixed. Thanks for reporting.
Comment 4 Mike Gilbert gentoo-dev 2013-02-17 16:11:48 UTC
Huh? None of it has been fixed. Maybe you forgot to commit your changes...
Comment 5 Mike Gilbert gentoo-dev 2013-05-09 23:24:51 UTC
*turses-0.2.13-r1 (09 May 2013)

  09 May 2013; Mike Gilbert <floppym@gentoo.org> +turses-0.2.13-r1.ebuild,
  -turses-0.2.10.ebuild, -turses-0.2.11-r1.ebuild, -turses-0.2.11.ebuild,
  -turses-0.2.12.ebuild, -turses-0.2.9.ebuild:
  Convert to distutils-r1. Resolves bug 447604 by James Rowe. Remove old.