Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 447510 - Please stabilize =app-admin/logrotate-3.8.3
Summary: Please stabilize =app-admin/logrotate-3.8.3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Chema Alonso Josa (RETIRED)
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2012-12-16 19:10 UTC by Chema Alonso Josa (RETIRED)
Modified: 2013-01-01 19:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chema Alonso Josa (RETIRED) gentoo-dev 2012-12-16 19:10:45 UTC
For more than 4 weeks in the tree now. No bugs filed against it.

Arches please stablize.

Thanks.
Comment 1 Agostino Sarubbo gentoo-dev 2012-12-16 19:28:56 UTC
amd64 stable
Comment 2 Agostino Sarubbo gentoo-dev 2012-12-16 19:29:43 UTC
x86 stable
Comment 3 ahudson.news 2012-12-17 14:30:29 UTC
amd64, USE=acl and FEATURES=test, fails in "test 32", "setfacl: test.log: Operation not supported"



Portage 2.1.11.31 (default/linux/x86/10.0, gcc-4.5.4, glibc-2.15-r3, 3.5.7-gentoo i686)
=================================================================
System uname: Linux-3.5.7-gentoo-i686-Intel-R-_Core-TM-_i7-3520M_CPU_@_2.90GHz-with-gentoo-2.1
Timestamp of tree: Mon, 17 Dec 2012 11:30:01 +0000
ld GNU ld (GNU Binutils) 2.22
app-shells/bash:          4.2_p37
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.3-r2, 3.2.3
dev-util/cmake:           2.8.9
dev-util/pkgconfig:       0.27.1
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.9.6-r3, 1.11.6
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.5.4
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.6 (virtual/os-headers)
sys-libs/glibc:           2.15-r3
Repositories: gentoo x-local-overlay
ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="* -@EULA"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=native --param l1-cache-line-size=64 --param l1-cache-size=32 --param l2-cache-size=512 -O2 -funswitch-loops -fpredictive-commoning -fgcse-after-reload -ftree-vectorize -fomit-frame-pointer -mfpmath=sse -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native --param l1-cache-line-size=64 --param l1-cache-size=32 --param l2-cache-size=512 -O2 -funswitch-loops -fpredictive-commoning -fgcse-after-reload -ftree-vectorize -fomit-frame-pointer -mfpmath=sse -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -march=i686 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch protect-owned sandbox sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS="-O2 -march=i686 -pipe"
GENTOO_MIRRORS="ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gentoo ftp://ftp.ipv6.uni-muenster.de/pub/linux/distributions/gentoo ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo http://mirrors.sec.informatik.tu-darmstadt.de/gentoo/ http://de-mirror.org/distro/gentoo/"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage_local/local-overlay"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X acl acpi alsa anthy bash-completion berkdb bzip2 bzlib cjk cli cracklib crypt curl cxx dbus dhcp dri fam gdbm gnutls gtk hal iconv icq idn ipv6 jabber jpeg jpeg2k lzo mbox mime modules mozilla msn mudflap ncurses nls nptl numpy offensive openmp pam pcre pdf perl pic png posix pppd python readline session slang ssl svg tcpd truetype unicode vim-syntax vnc x86 zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="dummy virtualbox" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, MAKEOPTS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 4 ahudson.news 2012-12-17 14:51:43 UTC
actually, both x86 and amd64 fail the same test; emerge --info above was for x86, here is amd64:


Portage 2.1.11.31 (default/linux/amd64/10.0, gcc-4.4.5, glibc-2.14.1-r3, 2.6.39-gentoo x86_64)
=================================================================
System uname: Linux-2.6.39-gentoo-x86_64-Intel-R-_Atom-TM-_CPU_D525_@_1.80GHz-with-gentoo-2.0.3
Timestamp of tree: Tue, 11 Dec 2012 00:15:01 +0000
ld GNU ld (GNU Binutils) 2.22
ccache version 3.1.8 [disabled]
app-shells/bash:          4.2_p37
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.3-r2, 3.2.3
dev-util/ccache:          3.1.8
dev-util/cmake:           2.8.9
dev-util/pkgconfig:       0.27.1
sys-apps/baselayout:      2.0.3
sys-apps/openrc:          0.9.8.4
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.9.6-r3, 1.10.3, 1.11.6
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.4.5, 4.5.4
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r3
sys-kernel/linux-headers: 3.6 (virtual/os-headers)
sys-libs/glibc:           2.14.1-r3
Repositories: gentoo x-local-overlay
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fomit-frame-pointer"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /usr/share/openvpn/easy-rsa /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/games/angband/edit/ /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch protect-owned sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="ftp://ftp.uni-erlangen.de/pub/mirrors/gentoo ftp://ftp.halifax.rwth-aachen.de/gentoo/ http://mirrors.sec.informatik.tu-darmstadt.de/gentoo/ ftp://ftp.ipv6.uni-muenster.de/pub/linux/distributions/gentoo http://de-mirror.org/distro/gentoo/"
LANG="en_US.UTF-8"
LC_ALL="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j2 -l3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/tmp/portage"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/local-overlay"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa amd64 anthy apache2 bash-completion berkdb bitmap-fonts bzip2 bzlib cairo canna cjk cli cracklib crypt cscope curl cxx dbus dga dhcp dri encode esd exif fam ffmpeg flac fortran ftp fuse gdbm gif gtk hddtemp iconv icq idn imap imlib ipv6 jabber java jpeg jpeg2k kpathsea lapack libwww lm_sensors loop-aes lzo mad mbox mikmod mime mmx modules motif mozilla mp3 mpeg msn mudflap multilib ncurses nls nocd nptl nsplugin numpy offensive ogg opengl openmp pam pcre pdf pic png posix postgres pppd python qt3support quicktime rdesktop readline recode samba sdl session slang sockets socks5 sox spell sse sse2 ssl tcpd theora tiff truetype unicode vhosts vim-syntax vnc xml xv zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_dbd authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock dbd deflate dir disk_cache env expires ext_filter file_cache filter headers ident imagemap include info log_config logio mem_cache mime mime_magic negotiation proxy proxy_ajp proxy_balancer proxy_connect proxy_http rewrite setenvif so speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en en_GB de ja" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="dummy fbdev vesa intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 5 Chema Alonso Josa (RETIRED) gentoo-dev 2012-12-17 22:12:35 UTC
Could you please check the following?

Does your kernel provided ACL support?
Is your filesystem mounted with noacl?

Thanks for reporting.
Comment 6 ahudson.news 2012-12-18 12:47:06 UTC
From the x86 system, with gentoo-sources-3.5.7:

$ zgrep ACL /proc/config.gz 
CONFIG_EXT2_FS_POSIX_ACL=y
CONFIG_EXT3_FS_POSIX_ACL=y
CONFIG_EXT4_FS_POSIX_ACL=y
CONFIG_FS_POSIX_ACL=y
CONFIG_GENERIC_ACL=y
CONFIG_TMPFS_POSIX_ACL=y
CONFIG_NFS_V3_ACL=y
CONFIG_NFSD_V2_ACL=y
CONFIG_NFSD_V3_ACL=y
CONFIG_NFS_ACL_SUPPORT=m
# CONFIG_CIFS_ACL is not set

However there are no explicit acl-options in /etc/fstab or /proc/mounts for root including /var/tmp/portage:

rootfs / rootfs rw 0 0
/dev/root / ext3 rw,noatime,errors=remount-ro,barrier=1,data=writeback 0 0

Which means ACLs do not work on /var/tmp/portage:

/var/tmp/portage # mkdir test
/var/tmp/portage # setfacl -m u:bin:r test
setfacl: test: Operation not supported


This is the same error message as during test 32 - looks like it tries to test acl on the filesystem and they aren't enabled by default. (On a different local filesystem, with explicit "-o acl", ACLs work just fine.)
Comment 7 ahudson.news 2012-12-18 13:23:35 UTC
So probably the acl-related tests should be skipped when USE=acl is set but the build filesystem does not support ACLs - logrotate just inherits the global acl flag (which apparently nowadays comes by default via the default/linux/x86/10.0 profile).

And thanks for looking into it :)
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2012-12-18 17:14:20 UTC
Stable for HPPA.
Comment 9 Chema Alonso Josa (RETIRED) gentoo-dev 2012-12-18 20:05:35 UTC
(In reply to comment #7)
> So probably the acl-related tests should be skipped when USE=acl is set but
> the build filesystem does not support ACLs - logrotate just inherits the
> global acl flag (which apparently nowadays comes by default via the
> default/linux/x86/10.0 profile).
> 

Yes, we could check that case. The snippet below could do the job, but surely there is a smarter way.

df ${PORTAGE_TMPDIR} | tail  -n 1 | cut -d\  -f 1 | xargs -I {} grep {} /proc/mounts | cut -d\  -f 4 | grep "noacl"

Besides, I'm not sure if it would work for all the cases.
Comment 10 ahudson.news 2012-12-19 00:20:08 UTC
(In reply to comment #9)
> Yes, we could check that case. The snippet below could do the job, but
> surely there is a smarter way.
> 
> df ${PORTAGE_TMPDIR} | tail  -n 1 | cut -d\  -f 1 | xargs -I {} grep {}
> /proc/mounts | cut -d\  -f 4 | grep "noacl"
> 
> Besides, I'm not sure if it would work for all the cases.

This wouldn't work in my case - although the kernel and the relevant tools support ACLs, the filesystem itself doesn't have ACLs enabled by default (maybe mke2fs.conf didn't have "default_mntopts = acl,..." back then) and there are no "noacl" entries in /proc/mounts. I only see positive "acl" entries in /proc/mounts for the filesystems which have it explicitly enabled (via tune2fs, /etc/fstab or direct mount options).

So maybe check directly with setfacl/getfacl and depending on the result of that, continue or skip the tests? Actually setfacl should fail if not supported; getfacl will always work but would return only default u/g/o permissions.
Comment 11 Chema Alonso Josa (RETIRED) gentoo-dev 2012-12-19 23:02:21 UTC
(In reply to comment #10)
> (In reply to comment #9)
> 
> So maybe check directly with setfacl/getfacl and depending on the result of
> that, continue or skip the tests? Actually setfacl should fail if not
> supported; getfacl will always work but would return only default u/g/o
> permissions.

Yes, that sounds more reasonable. I've modified the test script to check that setfacl works properly. It works in this side.

+  19 Dec 2012; Chema Alonso <nimiux@gentoo.org>
+  files/logrotate-3.8.3-fix-acl-tests.patch:
+  Fixed tests to check for setfacl command wrt bug #447510 comment #10
Comment 12 ahudson.news 2012-12-20 10:46:19 UTC
Cheers, that works as intended :)

Thank you.
Comment 13 Agostino Sarubbo gentoo-dev 2012-12-22 13:51:03 UTC
ppc stable
Comment 14 Agostino Sarubbo gentoo-dev 2012-12-23 16:58:59 UTC
ppc64 stable
Comment 15 Markus Meier gentoo-dev 2012-12-24 14:04:24 UTC
arm stable
Comment 16 Agostino Sarubbo gentoo-dev 2012-12-26 15:33:26 UTC
ia64 stable
Comment 17 Agostino Sarubbo gentoo-dev 2012-12-30 13:55:28 UTC
sparc stable
Comment 18 Agostino Sarubbo gentoo-dev 2012-12-30 20:25:20 UTC
alpha stable
Comment 19 Raúl Porcel (RETIRED) gentoo-dev 2013-01-01 19:28:57 UTC
s390/sh stable