Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 447346 - [PATCH] =games-server/cyphesis-0.6.0 enable verbose build and pick the correct "ar" executable
Summary: [PATCH] =games-server/cyphesis-0.6.0 enable verbose build and pick the correc...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 447710
  Show dependency tree
 
Reported: 2012-12-15 13:04 UTC by Vicente Olivert Riera (RETIRED)
Modified: 2012-12-19 18:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
cyphesis-0.6.0.ebuild.patch (cyphesis-0.6.0.ebuild.patch,775 bytes, patch)
2012-12-15 13:04 UTC, Vicente Olivert Riera (RETIRED)
Details | Diff
cyphesis-0.6.0.ebuild.patch (cyphesis-0.6.0.ebuild.patch,775 bytes, patch)
2012-12-16 11:19 UTC, Vicente Olivert Riera (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vicente Olivert Riera (RETIRED) gentoo-dev 2012-12-15 13:04:49 UTC
Created attachment 332354 [details, diff]
cyphesis-0.6.0.ebuild.patch

Please stabilize =games-server/cyphesis-0.6.0

Target keywords: amd64 x86

The current stable version of this package will not compile against the future stable version of dev-games/wfmath. See bug #447162

I have attached a patch for this ebuild to fix the problems of "non-verbose build log" and calling AR directly.

Tested amd64: looks fine here.
Comment 1 Vicente Olivert Riera (RETIRED) gentoo-dev 2012-12-15 14:21:17 UTC
Tested x86: looks fine here.
Comment 2 Markos Chandras (RETIRED) gentoo-dev 2012-12-16 10:34:55 UTC
I am confused. Why do you ask for stabilization and attach a patch at the same time? It should be two different bugs. Please don't do that in the future. CC back arch teams once the patch is applied
Comment 3 Vicente Olivert Riera (RETIRED) gentoo-dev 2012-12-16 11:08:48 UTC
(In reply to comment #2)
> I am confused. Why do you ask for stabilization and attach a patch at the
> same time? It should be two different bugs. Please don't do that in the
> future. CC back arch teams once the patch is applied

The reason I did it in that way is simple: killing two birds with one stone.
The dev who mark it stable could apply the patch at the same time, and we avoid to flood bugzilla.

That's my explanation about why I did it in that manner. If you think that it's better to do it in two separate bugs, ok, I will do it in that manner in the future.

Thanks Markos.
Comment 4 Julian Ospald 2012-12-16 11:13:36 UTC
sorting inherit line alphabetically is not always a good idea

eclasses export phase functions and the last one always wins, thus switching the order can actually break ebuilds unless you know what you are doing

also note that it's policy for games ebuilds to inherit games.eclass last
Comment 5 Vicente Olivert Riera (RETIRED) gentoo-dev 2012-12-16 11:19:44 UTC
Created attachment 332460 [details, diff]
cyphesis-0.6.0.ebuild.patch

(In reply to comment #4)

Thanks Julian.
Comment 6 Tupone Alfredo gentoo-dev 2012-12-19 10:50:31 UTC
Fixed. Thanks for patch