The global USE=upnp is meant for UPnP port forwarding. There's also USE=upnp-av for some weird multimedia magic. What purpose does USE=upnp in vlc serve? The metadata.xml description is unclear. Please also fix/unify indentation in that file.
Let's see ... http://git.videolan.org/?p=vlc.git;a=blob;f=configure.ac;hb=HEAD > 3939 dnl > 3940 dnl UPnP Plugin (Intel SDK) > 3941 dnl > 3942 PKG_ENABLE_MODULES_VLC([UPNP], [upnp], [libupnp], [Intel UPNP SDK],[auto]) ..., we've got that already; but the actual file reveals more: http://git.videolan.org/?p=vlc.git;a=blob;f=modules/services_discovery/upnp_intel.cpp;h=b6fcaabee7397d5c79a0dbaaee4ccc933b0a772b;hb=a968c2427b3c25e47d617e3769c654acc8563f2c > 2 * Upnp_intel.cpp : UPnP discovery module (Intel SDK) > 11 * UPnP Plugin using the Intel SDK (libupnp) instead of CyberLink And thus: - <flag name="upnp">Enables support for Intel UPnP stack.</flag> + <flag name="upnp">Enables support for the Intel SDK stack based UPnP discovery module instead of CyberLink.</flag> + 22 Feb 2014; Tom Wijsman <TomWij@gentoo.org> metadata.xml: + Clarify USE flag upnp; fixes bug #447252, reported by mgorny.
Sorry but this is nowhere more helpful than the original description. Users need to know what they gain by enabling the flag, not how it's implemented. What feature it enables.
That module does UPnP discovery as stated in the description, which is a known concept, thus they know that they will gain that by enabling this; it is supposed to be a description of an USE flag, not a manual.
(In reply to Tom Wijsman (TomWij) from comment #3) > That module does UPnP discovery as stated in the description, which is a > known concept, thus they know that they will gain that by enabling this; it > is supposed to be a description of an USE flag, not a manual. Discovery of what? Routers? A/V sources? Coffee makers? And if it's about A/V, wouldn't USE=upnp-av fit better?
(In reply to Michał Górny from comment #4) > (In reply to Tom Wijsman (TomWij) from comment #3) > > That module does UPnP discovery as stated in the description, which is a > > known concept, thus they know that they will gain that by enabling this; it > > is supposed to be a description of an USE flag, not a manual. > > Discovery of what? Routers? A/V sources? Coffee makers? All of them! UPnP discovery = SSDP (Simple Service Discovery Protocol), it discovers services. > And if it's about A/V, wouldn't USE=upnp-av fit better? Maybe, maybe not; that depends on the services. Given that the module says it does discovery, we know that it does just that; and thus the description fits.
