Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 447182 - xfce-base/xfce4-panel-4.10.0 problem loading icons with absolute path
Summary: xfce-base/xfce4-panel-4.10.0 problem loading icons with absolute path
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-14 01:26 UTC by Carlos Silva
Modified: 2013-01-13 06:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix-icons-not-probably-resizing-when-requested.patch (0001-Fix-icons-not-probably-resizing-when-requested.patch,1.35 KB, patch)
2012-12-14 01:27 UTC, Carlos Silva
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Silva 2012-12-14 01:26:47 UTC
When loading icons to create the buttons and menus, xfce uses a function that is not really resizing icons and makes "absolute-path" loaded icons appear at their original size, and some of them an HUGE. As it also has some code available on the same function to do the scaling, I created a simple patch that loads the original image without scaling it and the forces it to scale using the code available.

Reproducible: Always

Steps to Reproduce:
1. emerge xfce4-panel
2. install some package that has a huge icon (eclipse-sdk-bin on java-overlay for example)
Actual Results:  
The icon displayed on the Development Menu is HUGE

Expected Results:  
Icon should be of normal size

Upstream bug is here: https://bugzilla.xfce.org/show_bug.cgi?id=9615
Comment 1 Carlos Silva 2012-12-14 01:27:19 UTC
Created attachment 332256 [details, diff]
Fix-icons-not-probably-resizing-when-requested.patch

Patch submitted upstream
Comment 2 Carlos Silva 2013-01-12 16:23:16 UTC
Got merged upstream today:

http://git.xfce.org/xfce/xfce4-panel/commit/?id=48e1016394fa6bdb1d708823a23a12641482a561
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2013-01-13 06:02:37 UTC
nice, exactly how this should go ;-)

+*xfce4-panel-4.10.0-r1 (13 Jan 2013)
+
+  13 Jan 2013; Samuli Suominen <ssuominen@gentoo.org>
+  +xfce4-panel-4.10.0-r1.ebuild, +files/xfce4-panel-4.10.0-icons.patch:
+  Fix icons not probably resizing when requested wrt #447182 by Carlos Silva.
+  The patch is from upstream git.