Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 446868 - app-emacs/ocaml-mode: Autoloading failed to define function inferior-caml-mode-font-hook
Summary: app-emacs/ocaml-mode: Autoloading failed to define function inferior-caml-mod...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Team for the ML programming language family
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-12-11 11:53 UTC by sgbmyr
Modified: 2013-04-29 12:47 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
50ocaml-mode-gentoo.el patch (patch-50ocaml-mode-gentoo.el,915 bytes, patch)
2012-12-11 11:53 UTC, sgbmyr
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description sgbmyr 2012-12-11 11:53:19 UTC
Created attachment 332042 [details, diff]
50ocaml-mode-gentoo.el patch

Steps to reproduce:

1. Start emacs
2. Open an Ocaml file
3. Start the the ocaml subshell 

Now the minibuffer displays: Autoloading failed to define function inferior-caml-mode-font-hook

This is probably due to the fact that caml-font.el does not define a function with such a name. Most probably the function 'inferior-caml-set-font-lock' should be called.

I attached a patch that resolves this problem.
Comment 1 Ulrich Müller gentoo-dev 2012-12-11 22:01:52 UTC
Thanks. The name of the function had changed between versions 3.10.0 and 3.10.2.
I wonder why nobody had noticed this before.

> Created attachment 332042 [details, diff] [details, diff]
> 50ocaml-mode-gentoo.el patch

Hm, I believe that the "add-hook" in the last line of the file should be updated for the new function name, too (and I've done this for -r1). Or is there any special reason why it shouldn't?

Anyway, ocaml-mode-3.12.1-r1 committed to CVS. Please test (and report back).
Comment 2 sgbmyr 2012-12-11 22:08:28 UTC
(In reply to comment #1)
> Thanks. The name of the function had changed between versions 3.10.0 and
> 3.10.2.
> I wonder why nobody had noticed this before.
> 
> > Created attachment 332042 [details, diff] [details, diff] [details, diff]
> > 50ocaml-mode-gentoo.el patch
> 
> Hm, I believe that the "add-hook" in the last line of the file should be
> updated for the new function name, too (and I've done this for -r1). Or is
> there any special reason why it shouldn't?
> 

No special reason, must have missed that line when I was re-doing the diff for the upload.

> Anyway, ocaml-mode-3.12.1-r1 committed to CVS. Please test (and report back).
Comment 3 sgbmyr 2013-04-29 11:52:34 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Thanks. The name of the function had changed between versions 3.10.0 and
> > 3.10.2.
> > I wonder why nobody had noticed this before.
> > 
> > > Created attachment 332042 [details, diff] [details, diff] [details, diff] [details, diff]
> > > 50ocaml-mode-gentoo.el patch
> > 
> > Hm, I believe that the "add-hook" in the last line of the file should be
> > updated for the new function name, too (and I've done this for -r1). Or is
> > there any special reason why it shouldn't?
> > 
> 
> No special reason, must have missed that line when I was re-doing the diff
> for the upload.
> 
> > Anyway, ocaml-mode-3.12.1-r1 committed to CVS. Please test (and report back).

So I did thorough testing and it works.

(Sorry for taking so long, didn't quite realize the "and report back" part...)
Comment 4 Ulrich Müller gentoo-dev 2013-04-29 12:47:17 UTC
Thanks for reporting and testing.