Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 446716 - app-text/qpdfview USE=-svg - UI shows no icons
Summary: app-text/qpdfview USE=-svg - UI shows no icons
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-10 12:04 UTC by tpeland
Modified: 2013-02-05 12:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
add svg by default to IUSE and warn if USE=-svg (qpdfview-0.3.5.patch,584 bytes, patch)
2012-12-10 12:04 UTC, tpeland
Details | Diff
removes USE=-svg option (qpdfview-0.3.5.patch,705 bytes, patch)
2012-12-17 06:31 UTC, tpeland
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tpeland 2012-12-10 12:04:54 UTC
Created attachment 331952 [details, diff]
add svg by default to IUSE and warn if USE=-svg

USE=-svg emerge app-text/qpdfview

Results with a binary that has no icons for example for "next page" and "previous page" and so on. Those buttons are shown by default but the user needs to click on the buttons blindly.

Attached patch does following for the ebuild:
-add svg by default to IUSE
-warn user about missing svg
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2012-12-10 12:09:08 UTC
Comment on attachment 331952 [details, diff]
add svg by default to IUSE and warn if USE=-svg

That is not an acceptable solution, I think. If the UI contains no icons with USE=-svg, then maybe the USE flag should be dropped entirely, instead.
Comment 2 tpeland 2012-12-17 06:31:31 UTC
Created attachment 332548 [details, diff]
removes USE=-svg option

Removes USE=-svg option. This way UI icons are always working.
Comment 3 Ben de Groot (RETIRED) gentoo-dev 2012-12-22 01:55:10 UTC
This seems to be a duplicate / resurfacing of bug #413653. I will contact upstream and see what is the best fix for this.

Either way, the svg useflag is enabled by default in the desktop profile, so I don't think we need to change enything there.
Comment 4 Michael Palimaka (kensington) gentoo-dev 2013-01-06 16:13:53 UTC
Can you paste your emerge --info please.

(For the record, I can't reproduce with my current configuration.)
Comment 5 Ben de Groot (RETIRED) gentoo-dev 2013-01-07 08:16:26 UTC
This is upstreams reply:

What is described seems to be the intended behavior as documented in
the README file: All fallback and application-specific icons are
shipped as SVG only for reasons of simplicity. (After cleaning the XML
code, the files are no larger than reasonably sized PNG files.)

The USE flag resp. build-time option is there, because one can very
well run the program without the supplied icons using those from an
FDo-compliant icon theme instead. (Especially, the default tool bar
buttons use FDo icons only.) So if one wishes to disable SVG, one
needs an FDo-compliant icon theme. (Of course, tool bar buttons for
application-specific actions will not be available this way and there
will be no application/window icon.)

(If the user's icon theme is not picked up because of the current
limitations of Qt-only environments, explicitly setting "iconTheme" in
the section "mainWindow" of the configuration file
"~/.config/qpdfview/qpdfview.conf" might help.)

P.S.: Another possible course of action that was taken by some
packagers, is to rasterize the SVG files and install them into the
"hicolor" icon theme which allows for disabling SVG support (and hence
the binary resource file containing the SVG icons) without reduced
functionality.
Comment 6 Davide Pesavento (RETIRED) gentoo-dev 2013-02-05 04:57:32 UTC
So... is this a bug or not? Should we just remove USE=svg and always enable svg support?
Comment 7 Ben de Groot (RETIRED) gentoo-dev 2013-02-05 12:48:48 UTC
+*qpdfview-0.3.7-r2 (05 Feb 2013)
+
+  05 Feb 2013; Ben de Groot <yngwin@gentoo.org> +qpdfview-0.3.7-r2.ebuild,
+  -qpdfview-0.3.6.ebuild, -qpdfview-0.3.7-r1.ebuild:
+  Enable svg by default for icons, otherwise depend on icon-theme. Fixes
+  bug#446716. Remove old.