Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 446704 - media-gfx/darktable-1.1.1 USE=doc - !!! dodoc: /var/tmp/portage/media-gfx/darktable-1.1.1/work/darktable-usermanual-1.1.1.pdf does not exist
Summary: media-gfx/darktable-1.1.1 USE=doc - !!! dodoc: /var/tmp/portage/media-gfx/dar...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Dane Smith (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-12-10 10:44 UTC by Vadim A. Misbakh-Soloviov (mva)
Modified: 2012-12-11 00:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (media-gfx:darktable-1.1.1:20121210-100812.log,377.00 KB, text/plain)
2012-12-10 10:44 UTC, Vadim A. Misbakh-Soloviov (mva)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vadim A. Misbakh-Soloviov (mva) gentoo-dev 2012-12-10 10:44:11 UTC
Created attachment 331942 [details]
build.log

I've tried to build darktable with USE="colord doc facebook flickr geo gphoto2 kde nls opencl openmp rawspeed slideshow -debug -gnome-keyring" VIDEO_CARDS="nvidia"
and discovered that it fails on install phase when trying to copy user manual from /var/tmp/portage/media-gfx/darktable-1.1.1/work/darktable-usermanual-1.1.1.pdf (where it shouldn't be in any case). Then I looked in /var/tmp/portage/media-gfx/darktable-1.1.1/work/darktable-1.1.1_build/doc/usermanual and discovered generated makefile, which don't do anything. then I looked in /var/tmp/portage/media-gfx/darktable-1.1.1/work/darktable-1.1.1/doc/usermanual and discovered file, named «CMakeLists.tx» (sic! exactly .tx)

Then I reemerged darktable with USE=-doc and it is installed flawlessly.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2012-12-10 11:36:39 UTC
--- darktable-1.1.1.ebuild      10 Dec 2012 04:30:54 -0000      1.1
+++ darktable-1.1.1.ebuild      10 Dec 2012 11:36:24 -0000
@@ -94,7 +94,7 @@
 
 src_install() {
        cmake-utils_src_install
-       use doc && dodoc "${WORKDIR}"/${PN}-usermanual-${PV}.pdf
+       use doc && dodoc "${DISTDIR}"/${PN}-usermanual-${PV}.pdf
 }
 
 pkg_preinst() {
Comment 2 Vadim A. Misbakh-Soloviov (mva) gentoo-dev 2012-12-10 12:10:51 UTC
(In reply to comment #1)
> +       use doc && dodoc "${DISTDIR}"/${PN}-usermanual-${PV}.pdf
> DISTDIR

uhm? I think, it is a bit more work than just fix WORKDIR there. As far as I understand, documentation doesn't build at all due to typo in CMakeLists.txt file naming.

And, alternativelly, yup, it is possible to install manual from DISTDIR, but then you also need to add it to SRC_URI ;)
Comment 3 Tim Harder gentoo-dev 2012-12-10 18:37:16 UTC
(In reply to comment #2) 
> uhm? I think, it is a bit more work than just fix WORKDIR there. As far as I
> understand, documentation doesn't build at all due to typo in CMakeLists.txt
> file naming.

Nope that's all it takes. I forgot to change the variable name.

> And, alternativelly, yup, it is possible to install manual from DISTDIR, but
> then you also need to add it to SRC_URI ;)

So then maybe you should look at the ebuild more closely next time. ;)

Fixed in CVS.
Comment 4 Vadim A. Misbakh-Soloviov (mva) gentoo-dev 2012-12-11 00:20:06 UTC
(In reply to comment #3)
> So then maybe you should look at the ebuild more closely next time. ;)
uhm... yes :D It seems, I was blind yesterday :D