Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 446578 - sys-apps/hwids-20121208.5 relies on persisting global variable changes (not PMS compliant)
Summary: sys-apps/hwids-20121208.5 relies on persisting global variable changes (not P...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-09 08:40 UTC by Michał Górny
Modified: 2013-01-02 04:34 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-12-09 08:40:26 UTC
The sys-apps/hwids ebuild modifies MAKEOPTS which:

a) is a global scope variable in portage,

b) isn't even guaranteed to be a public shell variable by PMS.

Therefore, it is disallowed to:

a) rely on its modifications being preserved for next phases,

b) rely on it being used by 'emake'.

Please fix the ebuild.
Comment 1 SpanKY gentoo-dev 2012-12-11 00:02:22 UTC
uhh, a ton of things rely on MAKEOPTS being an exported variable.  if the PMS were to take that away, you'd break quite a lot.

i'm not saying the existing code is the greatest, just that your logic isn't exactly compelling.

i'd point out existing code is full of quoting problems, and pkg_postinst lacks $ROOT support.
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2012-12-31 13:10:41 UTC
It's not like I can do much about $ROOT until udev gets a clue and allows me to tell it WHERE to put the bloody compiled database (bonus points if it would allow me to put this in /usr/share at compile time, and have it managed by Portage).

There should only be one quoting problem on the old code for $D — and that was low priority for me to fix, but it should be fine with the current one. I would have really preferred not to have to make it this complex anyway.
Comment 3 SpanKY gentoo-dev 2013-01-02 04:34:33 UTC
(In reply to comment #2)

based on their friendliness in general to things they don't use themselves, i'm guessing we'll be waiting a long time