Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 445230 - media-libs/mlt-0.8.6[qt4] - Make dependency on kde-base/kdelibs:4 optional.
Summary: media-libs/mlt-0.8.6[qt4] - Make dependency on kde-base/kdelibs:4 optional.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL: https://github.com/mltframework/mlt/p...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-11-29 17:50 UTC by Sławomir Nizio
Modified: 2013-01-20 18:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch on ebuild that fixes this (mlt-0.8.6.ebuild-linkage.patch,1.71 KB, patch)
2012-11-29 17:55 UTC, Sławomir Nizio
Details | Diff
patch to be applied on sources (mlt-0.8.6-kdelibs-automagic.patch,3.23 KB, patch)
2012-11-29 17:55 UTC, Sławomir Nizio
Details | Diff
add 'kdenlive' USE flag (mlt-0.8.6-r1.ebuild.patch,919 bytes, patch)
2012-11-29 17:57 UTC, Sławomir Nizio
Details | Diff
patch on ebuild that fixes this (mlt-0.8.6.ebuild-linkage.patch,1.09 KB, patch)
2012-11-29 18:00 UTC, Sławomir Nizio
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sławomir Nizio 2012-11-29 17:50:28 UTC
Patch send upstream, see "URL" above.
I have tested all relevant USE flag combinations with the changes I'll attach as patches and it is OK.

The dependency occurs when qt4 is in USE and kde-base/kdelibs:4 is installed.
When kdelibs is installed and when it's not, USE=qt4 makes libmltqimage.so to be built. Then, if kdelibs is on the system, the library links to libkdecore.so.5 ( :( ).

Reproducible: Always
Comment 1 Sławomir Nizio 2012-11-29 17:52:18 UTC
By the time I finished writing this comment above, the patch was merged! :O
Comment 2 Sławomir Nizio 2012-11-29 17:55:32 UTC
Created attachment 330956 [details, diff]
patch on ebuild that fixes this

The "brackets" change is stylish (avoids a subshell).
Comment 3 Sławomir Nizio 2012-11-29 17:55:58 UTC
Created attachment 330958 [details, diff]
patch to be applied on sources
Comment 4 Sławomir Nizio 2012-11-29 17:57:08 UTC
Created attachment 330960 [details, diff]
add 'kdenlive' USE flag

This adds 'kdenlive' USE flag. This way one can enable linkage to KDE libs and this kdenlive thingy independently. Pretty please.
Comment 5 Sławomir Nizio 2012-11-29 18:00:23 UTC
Created attachment 330966 [details, diff]
patch on ebuild that fixes this

corrected patch (please see this one first, then the one from comment 4)
Comment 6 Sławomir Nizio 2012-11-29 18:03:01 UTC
(In reply to comment #4)
> Created attachment 330960 [details, diff] [details, diff]
> add 'kdenlive' USE flag
> 
> This adds 'kdenlive' USE flag. This way one can enable linkage to KDE libs
> and this kdenlive thingy independently. Pretty please.

By the way, this of course means that kdenlive ebuild should be updated: from media-libs/mlt[kde] to media-libs/mlt[kdenlive].
Comment 7 Sławomir Nizio 2012-11-30 16:50:57 UTC
Regarding bug title change: it's not just about making the dependency optional; it's about solving the automagic dependency issue, and - an extension to fixing this issue - adding a new USE flag to provide choice for two different needs.
Comment 8 Ben de Groot (RETIRED) gentoo-dev 2013-01-20 18:40:18 UTC
+*mlt-0.8.6-r1 (20 Jan 2013)
+
+  20 Jan 2013; Ben de Groot <yngwin@gentoo.org>
+  +files/mlt-0.8.6-kdelibs-automagic.patch, +mlt-0.8.6-r1.ebuild, metadata.xml:
+  Add kdelibs-automagic patch, which has already been accepted upstream. Add
+  kdenlive useflag, as it is separately configurable from linking to kdelibs.
+  Fixes bug #445230. Thanks to Enlik for the patches.
Comment 9 Sławomir Nizio 2013-01-20 18:42:40 UTC
thanks :)