Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 445174 - media-tv/xbmc - include limits.h in NFSDirectory.cpp to make it compatible with newer libnfs versions
Summary: media-tv/xbmc - include limits.h in NFSDirectory.cpp to make it compatible wi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Xbox project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-11-29 11:44 UTC by Winfried Lorenzen
Modified: 2012-12-08 18:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to let XBMC compile with libnfs master and the upcoming release (NFS_limits.patch,340 bytes, text/plain)
2012-11-29 11:44 UTC, Winfried Lorenzen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Winfried Lorenzen 2012-11-29 11:44:49 UTC
Created attachment 330916 [details]
Patch to let XBMC compile with libnfs master and the upcoming release

Compiling XBMC-11.0 with the current master version of libnfs (a new release is in preparation) fails due to a missing include in NFSDirectory.cpp (which was probably included indirectly through the rpc headers). Since libnfs removed the dependence on the rpc headers the build fails. For details see https://github.com/sahlberg/libnfs/issues/24

The change was already accepted upstream for the upcoming XBMC 12.0 release (see https://github.com/xbmc/xbmc/pull/1854).

The attached patch was tested with the current media-tv/xbmc-11.0-r1 ebuild and net-fs/libnfs-9999 and fixes bug https://bugs.gentoo.org/show_bug.cgi?id=442588

The patch does not break compatibility with the currently stable libnfs-1.3.0, but helps resolving https://bugs.gentoo.org/show_bug.cgi?id=442588 and should be included in XBMC-11.0.
Comment 1 Frédéric Romagné 2012-12-05 18:32:17 UTC
could we then also add the nfs USE flag to media-tv/xbmc (only in 9999 for the moment)
Comment 2 SpanKY gentoo-dev 2012-12-08 18:21:58 UTC
should be all set now in the tree; thanks for the report!

Commit message: Add fix from upstream for building with newer libnfs
http://sources.gentoo.org/media-tv/xbmc/files/xbmc-11.0-nfs-limits.patch?rev=1.1
http://sources.gentoo.org/media-tv/xbmc/xbmc-11.0-r1.ebuild?r1=1.2&r2=1.3
http://sources.gentoo.org/media-tv/xbmc/xbmc-11.0.ebuild?r1=1.18&r2=1.19