Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 444730 - sys-libs/libutempter: please review prefix changes
Summary: sys-libs/libutempter: please review prefix changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: Inclusion, InVCS, PATCH
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2012-11-25 19:38 UTC by Christoph Junghans (RETIRED)
Modified: 2012-11-26 15:57 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
patch against libutempter-1.1.6.ebuild (libutempter-1.1.6.ebuild.patch,1.81 KB, patch)
2012-11-25 19:38 UTC, Christoph Junghans (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Junghans (RETIRED) gentoo-dev 2012-11-25 19:38:02 UTC 
Created attachment 330568 [details, diff]
patch against libutempter-1.1.6.ebuild

Changes to be added as libutempter-1.1.6-r1:
- prefixed include, mandir and libdir
- don't run fowners and fperms in prefix
- ${ROOT} -> ${EROOT}
- added prefix keywords
Comment 1 SpanKY gentoo-dev 2012-11-26 06:04:02 UTC 
Comment on attachment 330568 [details, diff]
patch against libutempter-1.1.6.ebuild

>-	fowners root:utmp /usr/$(get_libdir)/misc/utempter/utempter
>-	fperms 2755 /usr/$(get_libdir)/misc/utempter/utempter
>+	use prefix || fowners root:utmp /usr/$(get_libdir)/misc/utempter/utempter
>+	use prefix || fperms 2755 /usr/$(get_libdir)/misc/utempter/utempter

merge into a single if statement:

 if ! use prefix ; then
    ... fowners/fperms stuff ...
 fi

fix that and feel free to commit
Comment 2 Christoph Junghans (RETIRED) gentoo-dev 2012-11-26 15:57:26 UTC 
Committed, thanks.