The patches introduce systemd's sd_notify(3) to tell systemd that the service is ready. They should be applied after all other patches for both r1 and r2. The service file (doc/aiccu.service) enable systemd to control aiccu. The aiccu.service is defined to start after the network.target. It probably should not be so because aiccu provides network connectivity, but there is no network-ipv4.target which could provide IPv4 required for aiccu. Any comments on this are welcome. Reproducible: Always
Created attachment 330542 [details, diff] Systemd support for net-misc/aiccu-2007.01.15-r1
Created attachment 330544 [details] Systemd support for net-misc/aiccu-2007.01.15-r2
Created attachment 330546 [details, diff] Systemd support for net-misc/aiccu-2007.01.15-r2
CC: maciej.grela@gmail.com did not match anything Please fix metadata.xml
(In reply to comment #4) > CC: maciej.grela@gmail.com did not match anything > > Please fix metadata.xml + 01 Dec 2012; Michael Weber <xmw@gentoo.org> metadata.xml: + Removing Maciej from metadata.xml +
ping?
This patch needs systemd/sd-daemon.h to compile. I get the general idea and add #define HAVE_SYSTEMD
Since -r2 got stabled, I dropped -r1. I've added -r3 with a modified version of the -r2 patch, see [1] for details. I could not test USE=systemd, because I have no system with the need header/libs. Please test and report errors or close RESO/FIXED. Thanks +*aiccu-2007.01.15-r3 (24 May 2013) + + 24 May 2013; Michael Weber <xmw@gentoo.org> +aiccu-2007.01.15-r3.ebuild, + +files/aiccu-2007.01.15-systemd.patch, -aiccu-2007.01.15-r1.ebuild: + Add systemd support (thanks Łukasz Stelmach, bug 444692) + [1] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-misc/aiccu/files/aiccu-2007.01.15-systemd.patch?view=log
Almost works. Please change: +ifeq (1,HAVE_SYSTEMD) to +ifeq (1,$(HAVE_SYSTEMD)) in the Makefile section of the patch.
(In reply to Łukasz Stelmach from comment #9) > Almost works. Please change: > +ifeq (1,$(HAVE_SYSTEMD)) done, revbump to force re-evaluation. +*aiccu-2007.01.15-r4 (27 May 2013) + + 27 May 2013; Michael Weber <xmw@gentoo.org> +aiccu-2007.01.15-r4.ebuild, + -aiccu-2007.01.15-r3.ebuild, files/aiccu-2007.01.15-systemd.patch: + Fix test in Makefile patch, thanks Łukasz Stelmach for testing +