Bug 444126 – dev-lang/spidermonkey-1.8.5 does not respect CFLAGS/CXXFLAGS

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Denis M. (Phr33d0m) 2012-11-21 06:21:30 UTC]

Hello, I've been through a couple of places and I'm not sure if this is intentional or a bug (I believe it's a bug).

$ ▶ ./blatt.sh /var/tmp/portage/logs/dev-lang\:spidermonkey-1.8.5-r2\:20121120-142353.log 
>>> dev-lang/spidermonkey-1.8.5: ISSUES FOUND
> Added extra -O:
x86_64-pc-linux-gnu-g++ -o checks.o -c  -I./dist/system_wrappers_js -include ./config/gcc_hidden.h -DOSTYPE=\"Linux6.6\" -DOSARCH=Linux -DEXPORT_JS_API -D__STDC_LIMIT_MACROS  -I. -I. -I./dist/include -I./dist/include/nsprpub  -I/usr/include/nspr   -I. -I./assembler -I./yarr  -fPIC  -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -march=native -msse4 -msse4.1 -msse4.2 -O2 -pipe -fno-strict-aliasing -pthread -pipe  -DNDEBUG -DTRIMMED -O3 -fstrict-aliasing -fomit-frame-pointer -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DENABLE_JIT=1   -DMOZILLA_CLIENT -include ./js-confdefs.h -MD -MF .deps/checks.pp ./v8-dtoa/checks.cc
x86_64-pc-linux-gnu-g++ -o conversions.o -c  -I./dist/system_wrappers_js -include ./config/gcc_hidden.h -DOSTYPE=\"Linux6.6\" -DOSARCH=Linux -DEXPORT_JS_API -D__STDC_LIMIT_MACROS  -I. -I. -I./dist/include -I./dist/include/nsprpub  -I/usr/include/nspr   -I. -I./assembler -I./yarr  -fPIC  -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -march=native -msse4 -msse4.1 -msse4.2 -O2 -pipe -fno-strict-aliasing -pthread -pipe  -DNDEBUG -DTRIMMED -O3 -fstrict-aliasing -fomit-frame-pointer -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DENABLE_JIT=1   -DMOZILLA_CLIENT -include ./js-confdefs.h -MD -MF .deps/conversions.pp ./v8-dtoa/conversions.cc



Reproducible: Always




Portage 2.2.0_alpha142 (default/linux/amd64/10.0/desktop/kde, gcc-4.7.2, glibc-2.16.0, 6.6.6 x86_64)
=================================================================
System uname: Linux-6.6.6-x86_64-Intel-R-_Core-TM-_i7-2600K_CPU_@_3.40GHz-with-gentoo-2.2
Timestamp of tree: Tue, 20 Nov 2012 08:45:01 +0000
ld GNU ld (GNU Binutils) 2.23.1
app-shells/bash:          4.2_p39
dev-java/java-config:     2.1.12
dev-lang/python:          2.7.3-r2, 3.2.3-r1
dev-util/cmake:           2.8.10.1
dev-util/pkgconfig:       0.27.1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.11.5
sys-apps/sandbox:         2.6
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.10.3, 1.11.6, 1.12.5
sys-devel/binutils:       2.23.1
sys-devel/gcc:            4.6.3, 4.7.2
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.6 (virtual/os-headers)
sys-libs/glibc:           2.16.0
Repositories: gentoo x-portage
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/openvpn/easy-rsa /usr/share/polkit-1/actions /usr/share/themes/oxygen-gtk/gtk-2.0 /var/bind /var/lib/hsqldb"
CONFIG_PROTECT_MASK="${EPREFIX}/etc/gconf /etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -msse4 -msse4.1 -msse4.2 -O2 -pipe"
DISTDIR="/media/STORAGE/Personal/Documents/gentoo/distfiles"
EMERGE_DEFAULT_OPTS=""
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs clean-logs config-protect-if-modified distlocks fail-clean fixlafiles merge-sync news nodoc parallel-fetch parallel-install preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.ovh.net/gentoo-distfiles/ http://mirrors.telepoint.bg/gentoo/ http://ftp.spline.inf.fu-berlin.de/mirrors/gentoo/ http://gentoo-euetib.upc.es/mirror/gentoo/"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="bg en en_US es es_ES"
MAKEOPTS="-j10"
PKGDIR="/media/STORAGE/Personal/Documents/gentoo/packages"
PORTAGE_COMPRESS="xz"
PORTAGE_COMPRESS_FLAGS="-9"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="-4"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://188.165.231.20/gentoo-portage"
USE="X a52 aac acl acpi alsa amd64 apng ares avx bash-completion berkdb bluetooth bluray branding bzip2 cairo cli consolekit cracklib cxx dbus declarative dri dts dvdr emboss encode exif fam firefox flac fortran gdbm gif gpm gstreamer gtk gzip iconv icu ipv6 jpeg kde kdm kipi lcms ldap libnotify lm_sensors lzma mad matroska mmx mng modules mp3 mp4 mpeg mudflap multilib ncurses nls nptl nsplugin offensive ogg opencl opengl openmp pam pango pcre pdf perl phonon plasma png policykit ppds pppd python qt3support qt4 readline sdl session spell sse sse2 sse3 sse4 sse4_1 ssl ssse3 startup-notification svg tcpd tiff truetype udev udisks unicode upower usb vorbis wxwidgets x264 xcb xcomposite xinerama xml xscreensaver xv xvid zlib" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="bg en en_US es es_ES" PHP_TARGETS="php5-3" PYTHON_TARGETS="python2_7 python3_2" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="fglrx" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, USE_PYTHON

[Comment 1 Denis M. (Phr33d0m) 2012-11-21 06:22:14 UTC]

Created attachment 330108 [details]
build log: dev-lang:spidermonkey-1.8.5-r2.log

[Comment 2 Julian Ospald 2014-05-17 17:32:42 UTC]

is there a technical reason this is not fixed?

:24 is still affected

[Comment 3 Jory A. Pratt 2014-05-17 21:45:24 UTC]

(In reply to Julian Ospald (hasufell) from comment #2)
> is there a technical reason this is not fixed?
> 
> :24 is still affected

There are much bigger bugs that are being addressed the minor little annoyances such as this.

[Comment 4 Julian Ospald 2014-05-17 22:07:48 UTC]

(In reply to Jory A. Pratt from comment #3)
> (In reply to Julian Ospald (hasufell) from comment #2)
> > is there a technical reason this is not fixed?
> > 
> > :24 is still affected
> 
> There are much bigger bugs that are being addressed the minor little
> annoyances such as this.

O3 can cause bugs as well. I'll try to come up with a patch.

[Comment 5 Julian Ospald 2014-05-17 22:16:39 UTC]

Created attachment 377158 [details, diff]
spidermonkey-24.2.0-r1.ebuild.diff

[Comment 6 Julian Ospald 2014-05-17 22:19:39 UTC]

Created attachment 377160 [details, diff]
spidermonkey-17.0.0-r3.ebuild.diff

[Comment 7 Julian Ospald 2014-05-17 22:27:05 UTC]

hm, I think that did not catch all

[Comment 8 Julian Ospald 2014-05-17 22:33:06 UTC]

Created attachment 377162 [details, diff]
spidermonkey-24.2.0-r1.ebuild.diff

This should catch all of them. The patch is the same for all 3 slots.

[Comment 9 Ian Stakenvicius (RETIRED) 2014-05-29 16:57:37 UTC]

Thanks for the patch!

Jory, your thoughts on whether this should be applied unconditionally or if maybe we should add "custom-cflags / custom-optimization" (via mozcoreconf-2.eclass) now, to normalize spidermonkey with the other mozilla packages?

[Comment 10 Jory A. Pratt 2014-05-30 01:07:41 UTC]

(In reply to Ian Stakenvicius from comment #9)
> Thanks for the patch!
> 
> Jory, your thoughts on whether this should be applied unconditionally or if
> maybe we should add "custom-cflags / custom-optimization" (via
> mozcoreconf-2.eclass) now, to normalize spidermonkey with the other mozilla
> packages?

It is fine unconditionally.

[Comment 11 Ian Stakenvicius (RETIRED) 2014-06-02 11:47:58 UTC]

Fixed in :24

+  02 Jun 2014; Ian Stakenvicius (_AxS_) <[e-mail]>
+  -spidermonkey-24.2.0-r1.ebuild, spidermonkey-24.2.0-r2.ebuild:
+  dropped optimizations so build system will respect cflags, bug 444126, thanks
+  to hasufell for patches; removed old :24 ebuild

[Comment 12 Jory A. Pratt 2015-01-06 14:35:33 UTC]

Has been fixed for some time now.