Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 443918 - media-sound/spotify allow spotify-dbus to work without gnome
Summary: media-sound/spotify allow spotify-dbus to work without gnome
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Matthew Thode ( prometheanfire )
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-11-19 12:14 UTC by selckin
Modified: 2012-11-20 20:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
spotify-dbus-optional-gnome.patch (spotify-dbus-optional-gnome.patch,1.17 KB, patch)
2012-11-19 12:14 UTC, selckin 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description selckin 2012-11-19 12:14:19 UTC 
spotify-dbus.py errors out when gnome-settings-manager is not installed, because it cannot use the 'org.gnome.SettingsDaemon.MediaKeys' dbus interface, attached patch ignores this error
Comment 1 selckin 2012-11-19 12:14:44 UTC 
Created attachment 329944 [details, diff]
spotify-dbus-optional-gnome.patch
Comment 2 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2012-11-19 14:47:31 UTC 
submitted patch upstream, if no-one responds 'soon' I will patch myself in the ebuild.
Comment 3 Mark R. Pariente 2012-11-20 05:16:51 UTC 
Merged upstream.
Comment 4 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2012-11-20 05:40:04 UTC 
fixed in gnome-integration-spotify-20121119
Comment 5 Mark R. Pariente 2012-11-20 18:26:47 UTC 
Matthew, there was some indentation issue with your patch that broke the script (spotify wouldn't launch). My bad for merging without testing - I've submitted a fix and tagged 20121120, please update the ebuild.
Comment 6 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2012-11-20 20:03:46 UTC 
Removed 20121119 and replaced with 20121120, yay tabs.  Thanks for catching it.