Bug 443560 – Stabilize games-fps/sauerbraten-2010.07.28

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mr. Bones. (RETIRED) 2012-11-16 21:05:25 UTC]

Please mark sauerbraten-2010.07.28.ebuild stable.

[Comment 1 Jean-Pierre de la Croix (jdelacroix) 2012-11-17 16:52:04 UTC]

amd64 tested ok

I am attaching a patch for the ebuild with some suggested changes.

[Comment 2 Jean-Pierre de la Croix (jdelacroix) 2012-11-17 16:53:53 UTC]

Created attachment 329730 [details]
Patch against ebuild with suggested changes.

Suggested changes:

1. '|| die' for cp, rm, etc.
2. repoman complains that RDEPEND is only implicitly declared, so RDEPEND replaces DEPEND, and DEPEND="${RDEPEND}", which stops repoman from complaining.

[Comment 3 Julian Ospald 2012-11-17 17:01:58 UTC]

(In reply to comment #2)
> Created attachment 329730 [details]
> Patch against ebuild with suggested changes.
> 
> 2. repoman complains that RDEPEND is only implicitly declared, so RDEPEND
> replaces DEPEND, and DEPEND="${RDEPEND}", which stops repoman from
> complaining.

that's a repoman bug. It should rather complain on EAPI >= 4 if RDEPEND is not set instead of bothering us about valid EAPI-3 syntax. Screw it.

[Comment 4 Julian Ospald 2012-11-17 17:04:14 UTC]

hm, actually it should not complain at all about this. RDEPEND might be empty on purpose.

[Comment 5 Agostino Sarubbo 2012-11-18 15:59:39 UTC]

amd64 stable

[Comment 6 Agostino Sarubbo 2012-12-04 15:37:48 UTC]

x86 stable. Last arch, closing