net-fs/libnfs-1.3.0 crashes newer XBMC due to the unconditional --enable-tirpc I'll attach a patch to the ebuild that lets you choose to enable / disable libtirpc at compile time via use flag. The use flag 'tirpc' is an "invented" one, please feel free to change it to something more appropriate. Reproducible: Always
Created attachment 329092 [details, diff] Patch for libnfs-1.3.0.ebuild
Created attachment 329094 [details, diff] Patch for libnfs-1.3.0.ebuild I just saw that in several other ebuilds, e.g. xinetd, libtirpc is enabled via the 'rpc' use flag. Thus, I changed my patch accordingly.
Created attachment 329096 [details, diff] Patch for libnfs-1.3.0.ebuild Just updated reordered the use flags alphabetically. :-)
Comment on attachment 329096 [details, diff] Patch for libnfs-1.3.0.ebuild that isn't what USE=rpc is for. that flag is for controlling the support of RPC services, not whether to use the C library or libtirpc. the C library is getting rid of RPC support and libtirpc is the only supported route. if there's a bug somewhere, it needs to be fixed.
(In reply to comment #4) > the C library is getting rid of RPC support and libtirpc is the only > supported route. if there's a bug somewhere, it needs to be fixed. Okay, but what is your suggestion? File an upstream bug? If yes, on what upstream? I'm not a C-programmer, so I don't know who to blame, libnfs, libtirpc, or even XBMC... :-(
Oh, there's already an open issue for the matter: https://github.com/sahlberg/libnfs/issues/24 So, I think this one can be closed.
I'm sorry, but I have to re-open this one. --enable-tirpc is now obsoleted for Linux platforms, so please remove that configure option completely from the ebuild. See the referenced upstream issue for details.
(In reply to comment #7) yeah, no. read comment #4 where i pointed out that rpc is being removed from the C library which means you have no choice but to use libtirpc.
(In reply to comment #8) > yeah, no. read comment #4 where i pointed out that rpc is being removed > from the C library which means you have no choice but to use libtirpc. Please, read at least the last few posts in the GitHub issue. The maintainer of libnfs already ships with his own rpc-implementation, independent from libc AND libtirpc. Thus, he removed the --enable-tirpc option completely, except for some "special" platforms like iOS and Android. According to the upstream bug report, using --enable-tirpc on Linux does more harm than just leaving it out.
(In reply to comment #9) ok, but we still need a new version. 1.3.0 uses external rpc symbols.
(In reply to comment #10) > ok, but we still need a new version. 1.3.0 uses external rpc symbols. Agreed. I'll contact the developer about it.
(In reply to comment #9) > ok, but we still need a new version. 1.3.0 uses external rpc symbols. Ronnie Sahlberg released 1.5.0 today, which comes with its own RPC implementation, completely independent of existing libs and headers: https://github.com/sahlberg/libnfs/commit/8afcdc959f1fe3d4b62566cab0f97135453e3d2c Please, bump. Thank you Torsten
should be all set now in the tree; thanks for the report! Commit message: Version bump. Disable libtirpc as upstream has deprecated it http://sources.gentoo.org/net-fs/libnfs/files/libnfs-1.5.0-headers.patch?rev=1.1 http://sources.gentoo.org/net-fs/libnfs/libnfs-1.5.0.ebuild?rev=1.1 http://sources.gentoo.org/net-fs/libnfs/libnfs-9999.ebuild?r1=1.2&r2=1.3
