Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 439846 - net-misc/asterisk: try to depend on gmime-2.6
Summary: net-misc/asterisk: try to depend on gmime-2.6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-27 10:54 UTC by Pacho Ramos
Modified: 2014-05-09 06:12 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
asterisk-10.9.0-major-version-first.patch (asterisk-10.9.0-major-version-first.patch,494 bytes, patch)
2012-10-27 11:19 UTC, Pacho Ramos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2012-10-27 10:54:30 UTC
Upstream is focusing in gmime-2.6 and this is the only package (with mu, bug #439842) still depending on gmime-2.4 and without any version in the tree without gmime-2.6 support. Could you check if it works with gmime-2.6?

Looking to configure.ac seems that it should work:
if test "x${PBX_GMIME}" = "x0" -a "${PKGCONFIG}" != "No"; then
        # Later versions of GMime use pkg-config
        for ver in 2.0 2.2 2.4 2.6; do
                if ! ${PKGCONFIG} --exists gmime-$ver; then
                        continue
                fi
                # If we got here, we have this version:
                GMIME_INCLUDE=$(${PKGCONFIG} gmime-$ver --cflags 2>/dev/null)
                GMIME_LIB=$(${PKGCONFIG} gmime-$ver --libs)
                PBX_GMIME=1
                AC_DEFINE([HAVE_GMIME], 1, [Define if your system has the GMIME libraries.])
                break;
        done
fi

the problem is that upstream should be contacted to either depend only in gmime-2.6 or reorder versions checking (listing versions in reverse order probably will work) because, otherwise, will be an automagic problem if both slots are installed and, later, gmime-2.4 is dropped (like has already being done in most major distributions)

Reproducible: Always
Comment 1 Pacho Ramos gentoo-dev 2012-10-27 11:19:48 UTC
Created attachment 327518 [details, diff]
asterisk-10.9.0-major-version-first.patch

And ebuild must be changed to:
--- asterisk-10.9.0.ebuild~	2012-10-27 13:09:21.000000000 +0200
+++ asterisk-10.9.0.ebuild	2012-10-27 13:09:51.000000000 +0200
@@ -49,7 +49,7 @@
 		net-misc/dahdi-tools )
 	freetds? ( dev-db/freetds )
 	gtalk? ( dev-libs/iksemel )
-	http? ( dev-libs/gmime:2.4 )
+	http? ( dev-libs/gmime:2.6 )
 	iconv? ( virtual/libiconv )
 	jabber? ( dev-libs/iksemel )
 	jingle? ( dev-libs/iksemel )
Comment 2 Tony Vroon (RETIRED) gentoo-dev 2012-10-28 08:46:45 UTC
Rediffed and included in patchset for 11.0.0 which is problematic for other reasons. If you want to help, bug #432894 please.
Comment 3 Pacho Ramos gentoo-dev 2012-10-28 09:30:39 UTC
(In reply to comment #2)
> Rediffed and included in patchset for 11.0.0 which is problematic for other
> reasons. If you want to help, bug #432894 please.

Have reviewed it but I don't know how to solve it :|
Comment 4 Tony Vroon (RETIRED) gentoo-dev 2012-10-30 00:31:23 UTC
+*asterisk-11.0.0 (30 Oct 2012)
+
+  30 Oct 2012; Tony Vroon <chainsaw@gentoo.org> +asterisk-11.0.0.ebuild,
+  metadata.xml:
+  Initial release on 11 (LTS) branch. Distro patchset & ebuild menuselect logic
+  ported by Oliver Jaksch. Build system tamed and parallelised by Erik Wallin.
+  Closes bug #432894. Patch from Pacho Ramos inverts logic in gmime detection
+  and facilitates the pending removal of 2.4 from the portage tree, closes bug
+  #439846. This is currently masked and not recommended for deployment.

Keeping bug open until the patch has made it into both the 1.8 stable branch and the 10 branch. To confirm long term planning, the 10 branch will never be marked stable and is slated to disappear from portage once the 11 branch has proven itself a capable replacement.
Comment 5 Tony Vroon (RETIRED) gentoo-dev 2012-12-02 12:46:42 UTC
To confirm, this has made it into all patch sets. With a suitably new 1.8 now being stabled; this is sorted everywhere. Thanks for identifying & fixing.
Comment 6 Pacho Ramos gentoo-dev 2014-04-25 19:31:08 UTC
Looks like 11.8.1 still pulls old slot even if configure checks for 2.6 :/
Comment 7 Tony Vroon (RETIRED) gentoo-dev 2014-05-06 12:22:35 UTC
Your supplied patch is in the set for all branches of Asterisk in the tree, with a filename of "invert-gmime-search-order.patch". Is it insufficient?
Comment 8 Pacho Ramos gentoo-dev 2014-05-06 18:15:39 UTC
But the dep on the ebuild is still:
        http? ( dev-libs/gmime:2.4 )

I would simply bump it to :2.6 slot to ensure the latest is used always
Comment 9 Tony Vroon (RETIRED) gentoo-dev 2014-05-08 09:41:27 UTC
+  08 May 2014; Tony Vroon <chainsaw@gentoo.org> asterisk-1.8.26.1.ebuild,
+  asterisk-1.8.27.0.ebuild, asterisk-11.8.1.ebuild, asterisk-11.9.0.ebuild,
+  asterisk-12.1.1.ebuild, asterisk-12.2.0.ebuild:
+  Update ebuild dependencies to ensure only the 2.6 slot of gmime is selected.
+  Inverting the search order in the configure script was only a partial fix. As
+  pointed out by Pacho Ramos in bug #439846.

Sorry about that.
Comment 10 Pacho Ramos gentoo-dev 2014-05-09 06:12:24 UTC
No problem, thanks :)