Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 438806 - app-emulation/winetricks should install a .desktop file
Summary: app-emulation/winetricks should install a .desktop file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-18 15:00 UTC by C. Wijtmans
Modified: 2016-03-31 13:12 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
wine-winetricks.desktop (wine-winetricks.desktop,155 bytes, patch)
2012-11-17 14:24 UTC, C. Wijtmans
Details | Diff
wine.desktop (file_438806.txt,1.19 KB, text/plain)
2012-12-01 22:56 UTC, C. Wijtmans
Details

Note You need to log in before you can comment on or make changes to this bug.
Description C. Wijtmans 2012-10-18 15:00:38 UTC
Using ubuntu on my laptop i saw a winetricks menu entry under wine.
It would be cool if gentoo did this as well.
Comment 1 SpanKY gentoo-dev 2012-10-19 00:18:52 UTC
winetricks is a shell script you run to install other packages.  adding a shortcut in the gui makes no sense for it.
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-10-19 00:59:07 UTC
(In reply to comment #1)

If you call recent versions of winetricks without command line arguments, it starts a substantial gui dialog tree which is rendered using gnome-extra/zenity. So a .desktop file for it does make sense; I'll take look at what ubuntu does.
Comment 3 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-10-19 05:50:24 UTC
Fixed in winetricks-916.

>*winetricks-916 (19 Oct 2012)
>
>  19 Oct 2012; Alexandre Rostovtsev <tetromino@gentoo.org>
>  -winetricks-909.ebuild, winetricks-913.ebuild, +winetricks-916.ebuild,
>  winetricks-99999999.ebuild:
>  Version bump. Install .desktop file and icon (bug #438806, thanks to C.J.
>  Wijtmans). Update license. Add dependencies on cabextract and unzip. Drop
>  old.
Comment 4 C. Wijtmans 2012-10-23 21:45:57 UTC
Hi Alex thank you for the .desktop file but here in KDE it is not appearing in my menu under Wine folder. I dont know what is wrong  i have no clue about desktop files.
Comment 5 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-10-23 22:21:38 UTC
(In reply to comment #4)
It should be in the "System" or "System tools" category in the menu (I am not sure what name kde uses for it).

I did not use "Wine" as the category because it's not in the list of categories permitted by the fredesktop.org menu standard; see http://standards.freedesktop.org/menu-spec/latest/apa.html, http://standards.freedesktop.org/menu-spec/latest/apas02.html, and http://standards.freedesktop.org/menu-spec/latest/apas03.html. Your setup might allow the non-standard "Wine" category, but other desktops don't.
Comment 6 C. Wijtmans 2012-10-27 19:34:26 UTC
Thank you i found it .. However i find it strange why the standard wouldnt support custom categories? Anyway when you install anything in WINE it already adds a "Wine" category, so it would just be the same WINE behavior, so why not under 'Wine'?
Comment 7 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-10-27 20:08:56 UTC
(In reply to comment #6)

As far as I can tell, it doesn't add them in a "Wine" category; instead, it seems to do some hackery with additional .menu files to move desktop entries from freedesktop categories into a new windows-like tree of categories. If you can figure out an appropriate way to do that for winetricks in a fashion that works both in gnome and kde and doesn't create an invalid .desktop file, I would be happy to add it.
Comment 8 C. Wijtmans 2012-11-17 14:24:07 UTC
Created attachment 329722 [details, diff]
wine-winetricks.desktop
Comment 9 C. Wijtmans 2012-11-17 14:25:04 UTC
(In reply to comment #8)
> Created attachment 329722 [details, diff] [details, diff]
> wine-winetricks.desktop

This is ubuntu's file, why cant we do it in gentoo as well? When you install Wine it already uses this Wine category, there is no way around it.
Comment 10 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-11-23 20:16:31 UTC
(In reply to comment #9)
> This is ubuntu's file, why cant we do it in gentoo as well?

Because this .desktop file does not work in gnome. The "Wine" category is non-standard and does not get recognized.
Comment 11 C. Wijtmans 2012-11-24 09:31:30 UTC
Then how does wine and its program folder get installed? It works in ubuntu(i think it uses gnome) and ubuntu with xfce and gentoo with kde.
Comment 12 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-11-24 23:47:19 UTC
With the wine-1.5.18 version bump, I've made the wine ebuild install a "Wine" category systemwide, like Ubuntu does, so the winetricks .desktop file can legitimately use "Wine" as the category (the ebuild still prints a QA warning on install, but it can be safely ignored now).

I've tracked down the problem in gnome to a long-standing bug in gnome-menus code (see https://bugzilla.gnome.org/show_bug.cgi?id=688972); it's now been patched in our gnome-menus-2.30.5-r1, 3.0.1-r2, 3.4.2-r1, and 3.6.1-r1 ebuilds. Thanks for motivating me to look into this issue carefully :)

>*winetricks-922 (24 Nov 2012)
>
>  24 Nov 2012; Alexandre Rostovtsev <tetromino@gentoo.org>
>  -winetricks-916.ebuild, +winetricks-922.ebuild, winetricks-99999999.ebuild:
>  Version bump. Use 'Wine' as the category for the .desktop file since our
>  >=wine-1.5.18 now provides applications-merged/wine.menu (bug #438806).
Comment 13 C. Wijtmans 2012-11-25 12:42:25 UTC
Alexander that is very clever, i would have never have come up with that. It is still a mystery to me how WINE displayed a Wine menu if there was no category for it. Anyway thank you a lot for your time for looking into it, it was learnful for me as well.
Comment 14 C. Wijtmans 2012-12-01 22:56:11 UTC
Created attachment 331168 [details]
wine.desktop

wine.desktop needs mime info.
Comment 15 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-12-08 04:08:24 UTC
(In reply to comment #14)
> wine.desktop needs mime info.

Mime info in wine.desktop is a potential security hole. See bug #117785
Comment 16 Jeroen Roovers (RETIRED) gentoo-dev 2012-12-08 05:58:45 UTC
So is that a WONTFIX/INVALID/DUPE?
Comment 17 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-12-08 06:23:42 UTC
(In reply to comment #16)
> So is that a WONTFIX/INVALID/DUPE?

It's "waiting for additional comments from Mike and the bug reporter".
Comment 18 C. Wijtmans 2012-12-08 14:07:13 UTC
Well if a malicious program detects the Z: folder in wine it  could cause some havoc in the users home folder but that would mean that the security hole is the default Z: folder in wine and not the mime type. If you download something or click something your action is because you want to open it. As far as i know mail clients dont download and open files for you. 

Tell me if my thinking is wrong?
Comment 19 Chiitoo gentoo-dev 2016-03-31 13:12:31 UTC
Teegrins!

The issues mentioned here in this bug seem to have been resolved (at least for the time being), and as such, I'll go ahead and bring it to closure.

Thank you for the report!