Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 437376 - net-analyzer/nessus-bin-5.0.1 version bump
Summary: net-analyzer/nessus-bin-5.0.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-06 09:04 UTC by Marek Szuba
Modified: 2012-10-12 06:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
systemd service unit file for the Nessus daemon (nessusd.service,144 bytes, text/plain)
2012-10-06 09:04 UTC, Marek Szuba
Details
nessus-bin-5.0.1-r1-ebuild.patch (nessus-bin-systemd-compat.patch,1.08 KB, patch)
2012-10-10 14:08 UTC, Sergey Popov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba archtester gentoo-dev 2012-10-06 09:04:24 UTC
Created attachment 325772 [details]
systemd service unit file for the Nessus daemon

Hello there!

The current version of Nessus is 5.0.1, however the latest version supported by the nessus-bin ebuild is 4.4.1. I would like to request an update. From what I can see all one has to do here is change the version number on the existing ebuild file, therefore I am not attaching an updated ebuild to conserve server storage space. Then again, I have attached a basic systemd unit file which appears to work fine with this version of nessus.

Let me know if you need any more information.
Comment 1 Sergey Popov gentoo-dev 2012-10-06 17:38:25 UTC
+*nessus-bin-5.0.1 (06 Oct 2012)
+
+  06 Oct 2012; Sergey Popov <pinkbyte@gentoo.org> +nessus-bin-5.0.1.ebuild:
+  Version bump wrt bug #437376
+

Ebuild for new version added to tree.
Can anybody from systemd team review attached file? I am not familiar with systemd at all...
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-10-07 08:13:35 UTC
(In reply to comment #1)
> Can anybody from systemd team review attached file? I am not familiar with
> systemd at all...

Well, it is fine if `nessus-service --quiet` doesn't fork. But you probably want to drop the 'Type=simple' line, it is the default.
Comment 3 Marek Szuba archtester gentoo-dev 2012-10-07 09:24:26 UTC
I believe it should be okay - nessus-service spawns nessusd but it does it via clone() instead of fork(), and more importantly it never terminates while the latter's running. In fact, a quick look at the output of strace run on nessus-service suggests it does the following:
 - installs custom signal handlers for its SIGINT, SIGTERM and SIGHUP, with the former two shutting things down (as expected) and the latter causing a configuration reload;
 - writes its own PID to /opt/nessus/var/nessus/nessus-service.pid;
 - clones itself and execs nessusd in the clone.
NB. It is entirely possible to launch nessusd directly, however it makes it impossible to use SIGHUP to reload configuration.
Comment 4 Sergey Popov gentoo-dev 2012-10-10 14:08:53 UTC
Created attachment 326190 [details, diff]
nessus-bin-5.0.1-r1-ebuild.patch

Thanks for comments, Michał. Can you review my patch for nessus-bin-5.0.1.ebuild, please? I am not sure, that i have used systemd eclass properly. If all is ok, i will commit new revision of ebuild among with attached service file
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-10-10 18:39:06 UTC
(In reply to comment #4)
> Created attachment 326190 [details, diff] [details, diff]
> nessus-bin-5.0.1-r1-ebuild.patch
> 
> Thanks for comments, Michał. Can you review my patch for
> nessus-bin-5.0.1.ebuild, please? I am not sure, that i have used systemd
> eclass properly. If all is ok, i will commit new revision of ebuild among
> with attached service file

No, it's not correct. You always install both files, USE=systemd has different semantics.
Comment 6 Sergey Popov gentoo-dev 2012-10-12 06:37:36 UTC
+*nessus-bin-5.0.1-r1 (12 Oct 2012)
+
+  12 Oct 2012; Sergey Popov <pinkbyte@gentoo.org> -nessus-bin-5.0.1.ebuild,
+  +nessus-bin-5.0.1-r1.ebuild, +files/nessusd-bin.service:
+  Revision bump, adding systemd service file wrt bug #437376