Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 437008 - sys-apps/systemd-189-r3 creates empty directories without .keep files
Summary: sys-apps/systemd-189-r3 creates empty directories without .keep files
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo systemd Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-02 19:33 UTC by Łukasz Stelmach
Modified: 2012-10-05 07:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Łukasz Stelmach 2012-10-02 19:33:11 UTC
It is easy to check that systemd provides several empty packages.

# tar tf /var/portage/packages/amd64/All/systemd-189-r3.tbz2  | grep binfmt
./etc/binfmt.d/
./usr/share/man/man5/binfmt.d.5.bz2
./usr/share/man/man8/systemd-binfmt.service.8.bz2
./usr/share/man/man8/systemd-binfmt.8.bz2
./usr/lib/systemd/system/systemd-binfmt.service
./usr/lib/systemd/system/sysinit.target.wants/systemd-binfmt.service
./usr/lib/systemd/system/sysinit.target.wants/proc-sys-fs-binfmt_misc.automount
./usr/lib/systemd/system/proc-sys-fs-binfmt_misc.mount
./usr/lib/systemd/system/proc-sys-fs-binfmt_misc.automount
./usr/lib/systemd/systemd-binfmt
./usr/lib/binfmt.d/

Shouldn't they (at least those in /etc) be filled with .keep files?

Reproducible: Always
Comment 1 Łukasz Stelmach 2012-10-02 19:34:27 UTC
I am sorry I've pasted the wrong example. Here is the right one.

# tar tf /var/portage/packages/amd64/All/systemd-189-r3.tbz2  | xargs -i find '{}' -maxdepth 0  -type d -empty
./etc/modules-load.d/
./etc/systemd/system/sysinit.target.wants/
./etc/systemd/system/local-fs.target.wants/
./etc/systemd/ntp-units.d/
./etc/tmpfiles.d/
./etc/binfmt.d/
./usr/lib/modules-load.d/
./usr/lib/systemd/system-shutdown/
./usr/lib/systemd/system-sleep/
./usr/lib/systemd/system/graphical.target.wants/
./usr/lib/systemd/user-generators/
./usr/lib/systemd/ntp-units.d/
./usr/lib/binfmt.d/
./var/lib/systemd/
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-10-03 15:39:20 UTC
Hmm, yes, you are probably right. But it feels stupid to keepdir all the empty directories created by the build system.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-10-03 15:50:12 UTC
(In reply to comment #1)
> I am sorry I've pasted the wrong example. Here is the right one.
> 
> # tar tf /var/portage/packages/amd64/All/systemd-189-r3.tbz2  | xargs -i
> find '{}' -maxdepth 0  -type d -empty
> ./etc/modules-load.d/

+.

> ./etc/systemd/system/sysinit.target.wants/
> ./etc/systemd/system/local-fs.target.wants/

Do we actually want that? I think systemd will create them if necessary anyway.

> ./etc/systemd/ntp-units.d/
> ./etc/tmpfiles.d/
> ./etc/binfmt.d/

+.

> ./usr/lib/modules-load.d/
> ./usr/lib/systemd/system-shutdown/
> ./usr/lib/systemd/system-sleep/
> ./usr/lib/systemd/system/graphical.target.wants/
> ./usr/lib/systemd/user-generators/
> ./usr/lib/systemd/ntp-units.d/
> ./usr/lib/binfmt.d/

Hmm.. assuming that /usr should be propagated using the package manager, it seems that these directories aren't necessary.

> ./var/lib/systemd/

+?
Comment 4 William Hubbs gentoo-dev 2012-10-03 17:10:08 UTC
I vaguely remember seeing this when I was working on building udev
separately.

If you canyou might want to look at this with automake-1.12.x installed;
I believe this is an automake bug that is fixed in that version of
automake.
Comment 5 William Hubbs gentoo-dev 2012-10-03 17:11:25 UTC
With the 1.12 series of automake, I don't believe those empty
directories get installed.
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-10-04 20:16:17 UTC
Added keepdirs in -194 and -9999.
Comment 7 Ulenrich 2012-10-04 21:04:43 UTC
M.Gorny, these empty -uneeded- directories are very helpfull to get a grip about systemd when beginning with that new init system!
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-10-05 07:09:05 UTC
(In reply to comment #7)
> M.Gorny, these empty -uneeded- directories are very helpfull to get a grip
> about systemd when beginning with that new init system!

Which ones? It should keep those in /etc.