436430 – net-dns/dnsmsasq should not use s-s-d for reload()

Bug 436430 - net-dns/dnsmsasq should not use s-s-d for reload()

Summary: net-dns/dnsmsasq should not use s-s-d for reload()

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	Normal minor (vote)
Assignee:	Patrick McLean

URL:
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:

Reported:	2012-09-27 18:40 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2012-10-02 02:36 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2012-09-27 18:40:58 UTC

The --oknodo option to s-s-d is now deprecated and is not supposed to be used. Also, there is no point in using s-s-d for something that is not starting or stopping a daemon ;)

My suggestion would be

reload() {
        ebegin "Reloading ${SVCNAME}"
        kill -HUP `cat ${pidfile}`
        eend $?
}

(the cat is for portability, $(<) is a bashism :()

Comment 1 Patrick McLean gentoo-dev

2012-10-02 02:36:41 UTC

Fixed, doesn't need a revbump as it's a relatively minor change.