Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 436212 - net-analyzer/wireshark could be patched to work with net-libs/gnutls-3
Summary: net-analyzer/wireshark could be patched to work with net-libs/gnutls-3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Peter Volkov (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on: 412219
Blocks: gnutls-3 CVE-2012-6052
  Show dependency tree
 
Reported: 2012-09-25 12:56 UTC by Bartosz Brachaczek
Modified: 2012-11-29 16:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
wireshark-1.8.2-gnutls3.patch (wireshark-1.8.2-gnutls3.patch,637 bytes, patch)
2012-09-25 12:56 UTC, Bartosz Brachaczek
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bartosz Brachaczek 2012-09-25 12:56:32 UTC
Created attachment 324940 [details, diff]
wireshark-1.8.2-gnutls3.patch

net-analyzer/wireshark blocks net-libs/gnutls-3. I know it's because upstream explicitly denies support for gnutls-3, but there is no technical reason to do so. Their reasoning is that they don't want to use gnutls-3 because to be able to legally redistribute wireshark binaries along with gnutls-3 binaries, it must be distributed as gpl-3(+)[1] (think win32/osx binaries). But everyone can compile wireshark with gnutls-3, only the resulting binaries will be gpl-3(+) instead of gpl-2(+).

Can wireshark be really compiled with gnutls-3?
Yes, gnutls-3 is mostly source compatible with gnutls-2.12[2]. Incompatibilities come down to some functions that were removed, but wireshark uses none of these. I checked and it compiles fine.

Isn't wireshark source code gpl-2-only?
No, the source code is gpl-2+, as can deduced from [1]. I checked it to be sure, and there are no gpl-2-only files (there are though some files dual-licenced under either gpl-2-only or 3-clause bsd but we can choose bsd here).

What is upstream status of this?
Nothing has changed so far. They don't want to use gnutls-3 because they don't want to switch to gpl-3. They would probably accept quality patches to replace gnutls dependency with nss, but there's no progress on it so far. Maybe it would be a good idea to have a patch upstreamed that could at least add some configure-time switch to allow gnutls-3?

[1] https://wireshark.org/lists/wireshark-dev/201203/msg00171.html
[2] http://www.gnu.org/software/gnutls/manual/html_node/Upgrading-from-previous-versions.html#Upgrading-from-previous-versions
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2012-10-03 17:28:48 UTC
Should be fixed in 1.8.3-r1. Please test and confirm.
Comment 2 Bartosz Brachaczek 2012-10-06 21:28:14 UTC
I tested whether it works, and unfortunately it doesn't. But it seems to be caused not by gnutls-3 itself, but by gnutls not using libgcrypt, as it doesn't work with gnutls-2[nettle] as well[1]. So IMHO the patch is still valid, as I expect the SSL dissector to work with gnutls-3 when it is made compatible with gnutls-2[nettle].

[1] See bug #412219.
Comment 3 Bartosz Brachaczek 2012-10-07 12:51:10 UTC
As I expected, it works correctly with my patch from bug #412219.