I've noticed that app-admin/durep doesn't specify any runtime dependencies, which I'm reporting. By the way I'll attach a small patch by me that fixes this: Switch will be removed from the Perl core distribution in the next major release . Please install it from CPAN. It is being used at ./durep, line 17. by switching to given/when. Note you need Perl 5.10 or newer for this. The patch I'll attach is intended to replace durep-0.9-color-output.patch. If you don't like it, I imagine adding a dependency on virtual/perl-Switch will keep it working with Perl 5.14+ too. (Switch has been removed from Perl core in releases since 5.14.) Reproducible: Always
Created attachment 324908 [details, diff] durep-0.9-r3.ebuild.patch
Created attachment 324910 [details, diff] durep-0.9-color-output-2.patch
Hi, Thanks for the report and patches. As this package is orphaned, I am not particularly familiar with it. Is there a benefit to updating the patch rather than just adding a dependency on virtual/perl-Switch?
(In reply to comment #3) > Hi, > > Thanks for the report and patches. > > As this package is orphaned, I am not particularly familiar with it. Is > there a benefit to updating the patch rather than just adding a dependency > on virtual/perl-Switch? The benefit it to use a smaller and perhaps more elegant patch. (Although not immediately - the previous one could be removed only when the new ebuild is stabilised, AFAIK.) Also, the change with colours seems to be Gentoo specific to add a feature - not even patch a bug - so why not provide a nicer "Gentoo patch" when such is available. :) Another good thing - not adding an extra dependency. Ooh and note that durep is keyworded for ppc, and virtual/perl-Switch and perl-core/Switch are not! :) However, adding the dependency should work too.
Please also remember about adding the missing RDEPEND.
I think we should rely on perl-core/Switch and not on this patch. It looks good, but IMO it is better to rely on upstream behaviour in this case.
(In reply to comment #6) > I think we should rely on perl-core/Switch and not on this patch. It looks > good, but IMO it is better to rely on upstream behaviour in this case. Note that the proposed patch is a replacement of an existing patch, so we are already deviating from upstream behaviour.
(In reply to comment #7) > Note that the proposed patch is a replacement of an existing patch, so we > are already deviating from upstream behaviour. exactly (In reply to comment #0) > by switching to given/when. Note you need Perl 5.10 or newer for this. I didn't realise it until recently, but old Perls (including < 5.10) are even masked. In other words, with this patch it works on every non-masked Perl.
virtual/perl-Switch is not stable, so we cannot depend on it. + 01 Dec 2012; Julian Ospald <hasufell@gentoo.org> durep-0.9-r3.ebuild: + fix dependencies wrt #436148
You fixed the dependency but it's still broken (or it will be broken) with some newer Perl versions…
(In reply to comment #10) > You fixed the dependency but it's still broken (or it will be broken) with > some newer Perl versions… no, cause I enforce the working perl version
(In reply to comment #9) > + 01 Dec 2012; Julian Ospald <hasufell@gentoo.org> durep-0.9-r3.ebuild: > + fix dependencies wrt #436148 CVS problems? I see the maintainership change, but not this one.
(In reply to comment #12) > (In reply to comment #9) > > + 01 Dec 2012; Julian Ospald <hasufell@gentoo.org> durep-0.9-r3.ebuild: > > + fix dependencies wrt #436148 > > CVS problems? I see the maintainership change, but not this one. whoops, I think it should be committed now @Enlik mixing stable and unstable is not supported I could do a revbump and use virtual/perl-Switch there instead of forcing perl-5.12, but then we will have two identical versions with just differing dependencies. I think I will just wait for virtual/perl-Switch to become stable and then fix the dep again, so it will be unlocked for ~arch users.
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-admin/durep/durep-0.9-r3.ebuild?r1=1.4&r2=1.5
(In reply to comment #13) > I could do a revbump and use virtual/perl-Switch there instead of forcing > perl-5.12, but then we will have two identical versions with just differing > dependencies. Please do, pinning the perl dependency breaks ~arch.
ok sry for that I'm arch user so I'm sometimes a bit careless about ~arch marked the virtual stable: + 01 Dec 2012; Julian Ospald <hasufell@gentoo.org> perl-Switch-2.160.0.ebuild: + stable for all since =dev-lang/perl-5.12* satisfies them + and fixed the dep to that one: 01 Dec 2012; Julian Ospald <hasufell@gentoo.org> durep-0.9-r3.ebuild: + unlock for ~arch users as well since virtual/perl-Switch is stable now +
Great, thanks.
You confused me to death with your previous comments. Glad to see this fixed. :) By the way, I'd like to paste a comment I made when you made one of yours, resulting in a "mid-air conflict", because I don't want to be unclear (I might have been). === (In reply to comment #8) > > by switching to given/when. Note you need Perl 5.10 or newer for this. > I didn't realise it until recently, but old Perls (including < 5.10) are > even masked. In other words, with this patch it works on every non-masked > Perl. Ugh, it might have been confusing. I meant there's no need to worry about old masked versions: [M]5.8.8-r8 [M](~)5.10.1 and regarding new masked versions: [M](~)5.14.1 [M](~)5.14.1-r1 [M](~)5.14.2 and even unmasked 5.16, I haven't tested it, but don't see why it wouldn't work on them. ===
well I first wanted to add virtual/perl-Switch to RDEPEND, but that was not stable then I just fixed the perl-dependency to the working version which still includes Switch (5.12), thus blocking it for ~arch users then I realized that virtual/perl-Switch can be stabilized already, since we only need one stable provider to stabilize the whole virtual
I think it is wrong to depend on a deprecated module (Switch) for a Gentoo downstream patch if an updated patch using the replacement feature usable with Perl 5.10 and above is already attached. Thanks Consider virtual/perl-Switch and perl-core/Switch masked and removed from the tree.
