Created attachment 324500 [details] redoflacs-0.14.1.ebuild Hello! This is an initial ebuild for package "redoflacs-0.14.1" Redoflacs is a command line BASH script that provides a convenient interface to manage a user's FLAC library, providing a way to retag, verify, validate and prune FLAC files. Also, there is exhaustive error handling and logging. In addition, this script has the option to use external programs such as SoX (to create spectrograms) and auCDtect (to check FLAC validity). I suggest the ebuild be placed as: media-sound/redoflacs Rationale: Other packages that manipulate media files (ie, EasyTag, MusicBrainz Picard, Amarok, MPD, etc) are all placed under media-sound. The core dependencies are: sys-apps/coreutils sys-apps/findutils sys-apps/gawk sys-apps/grep app-shells/bash media-libs/flac Additional dependencies (if wanted): sys-libs/ncurses sys-apps/less media-sound/sox media-libs/libpng The 'libpng' dependency is needed if using SoX's spectrogram option. I'm currently maintaining the ebuild at: https://github.com/sirjaren/gentoo-overlay/tree/master/media-sound/redoflacs First ebuild, thanks! Jaren
Thanks for submitting your ebuild! It looks good, but I'd like to propose a couple of improvements: 1) Use vcs-snapshot eclass, then you can leave out your src_unpack function. 2) Optional runtime dependencies should go to an elog message in pkg_postinst, since they do not warrant a re-install of this package.
Created attachment 324676 [details] redoflacs-0.14.1.ebuild Version two of redoflacs-0.14.1.ebuild. This incorporates the suggestions from Ben de Groot.
I just committed this. I have tightened up the ebuild a little more, especially by using exeinto/newexe, which makes src_install simpler. Concerning the program itself, I would suggest using the $PAGER environment variable instead of straight 'less' (I myself prefer using vimpager or most).
Created attachment 324678 [details] Bump redoflacs to 14.1.1 This bumps ebuild to version 0.14.1.1. This includes all the changes made by Ben de Groot. Also, explicit support for 'sys-apps/less' has been removed in favor of $PAGER, allowing a fallback if empty. Thanks Ben de Groot for all the help and suggestions! I really like the new src_install function you used. I'm still learning, no doubt, and this is a real treat! Since it seems that the sound herd is maintaining this, what's the best way to tackle new revisions? Create a separate bug with the new ebuild (most likely just a rename to the new program version) or update this bug? Thanks again!
(In reply to comment #4) > Since it seems that the sound herd is maintaining this, what's the best way > to tackle new revisions? Create a separate bug with the new ebuild (most > likely just a rename to the new program version) or update this bug? Bumped. For new releases, please open a new bug report. No need to attach an ebuild if it is the same. If there are changes, then please attach a diff (to the ebuild).
