First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 43563
Alias:
Product:
Component:
Status: CLOSED
Resolution: TEST-REQUEST
Assigned To: Gentoo Games <games@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Will McQueen <wjmcqueen@gmail.com>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
triplea-0.3.3.ebuild triplea-0.3.3.ebuild text/plain Will McQueen 2004-03-02 23:02 0000 1.82 KB Details
triplea-savedgamesdir.patch Patch to change saved games dir to ~/.triplea/savedGames patch Will McQueen 2004-03-02 23:02 0000 995 bytes Details | Diff
triplea-0.4.8-r1.diff 0.4.8 to 0.4.8-r1 diff with savedGames option text/plain Will McQueen 2004-07-07 21:39 0000 598 bytes Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 43563 depends on: Show dependency tree
Bug 43563 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.




View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2004-03-02 23:01 0000 
TripleA is an open source clone of the popular Axis and Allies boardgame.  It's
written in Java and built using Ant.

I took the liberty of modifying (via a patch) the saved games directory from
the installation directory to (~/.triplea/savedGames).  I also jar'ed up the
classes directory for simplification purposes.

Criticism of my ebuild style/technique is appreciated.

Reproducible: Always
Steps to Reproduce:

------- Comment #1 From Will McQueen 2004-03-02 23:02:04 0000 ------- 
Created an attachment (id=26747) [edit]
triplea-0.3.3.ebuild

------- Comment #2 From Will McQueen 2004-03-02 23:02:39 0000 ------- 
Created an attachment (id=26748) [edit]
Patch to change saved games dir to ~/.triplea/savedGames

------- Comment #3 From Mr. Bones. 2004-03-09 02:30:59 0000 ------- 
Quality ebuild.  Just a few minor comments:

trim trailing whitespace
dodir takes a list of directories, no need to call it multiple times
prefer sed to patch for small changes like this one
always stack depends vertically so they're easier to see
don't name the package again in the DESCRIPTION.  so, "A game..." instead of
     "Foo is a game..."
use unpack ${A} to unpack sources in the general case

When I first tried this ebuild, it failed to compile because I was missing junit
from my system.  Be sure to comb over the deps that are needed to build a
package successfully.

I touched up the ebuild and added it as games-strategy/triplea to CVS.  I
didn't test it with jikes since I don't have it installed, so it's in testing
until there's some additional feedback from someone who has jikes in their
USE flags.

------- Comment #4 From Mr. Bones. 2004-03-30 03:10:32 0000 ------- 
Seems to be working for people.  I went ahead and marked it stable in portage.

------- Comment #5 From Mr. Bones. 2004-06-10 00:50:52 0000 ------- 
Will - wanna take a shot at getting 0.4.8 working?  I don't know java well
enough to make it work and they've changed the code around upstream.

------- Comment #6 From Will McQueen 2004-06-10 07:36:08 0000 ------- 
Sure.  I should have some time this weekend, I'll see how far I can get.

------- Comment #7 From Will McQueen 2004-07-07 21:39:06 0000 ------- 
Created an attachment (id=34977) [edit]
0.4.8 to 0.4.8-r1 diff with savedGames option

This is a diff of the 0.4.8 ebuild that will create a file called
triplea.properties and stick it in the data dir.

This will default triplea's savedGames dir to the users home directory.
Sorry it took so long for me to get to it.

------- Comment #8 From Will McQueen 2004-07-07 21:40:49 0000 ------- 
Whoops, that diff is backwards.  I think I need to go to bed now.  :)
First Last Prev Next    No search results available      Search page      Enter new bug