Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 434258 - media-video/mplayer - add media-libs/libopus support
Summary: media-video/mplayer - add media-libs/libopus support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-09-07 21:16 UTC by Andrew Savchenko
Modified: 2013-02-08 13:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mplayer-9999.ebuild-opus.patch (mplayer-9999.ebuild-opus.patch,1.92 KB, patch)
2012-09-07 21:17 UTC, Andrew Savchenko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Savchenko gentoo-dev 2012-09-07 21:16:50 UTC
Hello,

live MPlayer now supports Opus audio decoder using media-libs/opus.

Proposed patch adds this support to the ebuild via "opus" USE flag, used by several other packages in the tree. Works fine for me on ~x86.
Comment 1 Andrew Savchenko gentoo-dev 2012-09-07 21:17:50 UTC
Created attachment 323168 [details, diff]
mplayer-9999.ebuild-opus.patch

A libopus support patch for the live ebuild.
Comment 2 Alexis Ballier gentoo-dev 2012-09-09 15:57:33 UTC
hmm it seems opus is done through ffmpeg, which already has the useflag

Index: etc/codecs.conf
===================================================================
--- etc/codecs.conf	(revision 35045)
+++ etc/codecs.conf	(revision 35046)
@@ -5471,6 +5471,13 @@
   driver ffmpeg
   dll "vmdaudio"
 
+audiocodec fflibopus
+  info "FFmpeg libopus"
+  status working
+  fourcc opus ; internal MPlayer FourCC
+  driver ffmpeg
+  dll libopus
+
 audiocodec ffvorbis
   info "FFmpeg Vorbis"
   status working


wouldnt it be better to always opus to avoid the -lopus ? (with as-needed the library doesnt appear in the needed entries of mplayer)
Comment 3 Alexis Ballier gentoo-dev 2012-09-09 16:06:57 UTC
> wouldnt it be better to always opus to avoid the -lopus ? (with as-needed
                              ^^^^^ always _disable_ opus :)

> the library doesnt appear in the needed entries of mplayer)
Comment 4 Tomasz Golinski 2012-09-16 12:03:52 UTC
If mplayer really uses media-lib/opus, then I think that the choice of decoder (ffmpeg vs libopus) should be left to the user by appropriate USE flag (the same as it is now with e.g. mp3, vorbis, aac).
Comment 5 Alexis Ballier gentoo-dev 2012-09-16 15:30:32 UTC
(In reply to comment #4)
> If mplayer really uses media-lib/opus, then I think that the choice of
> decoder (ffmpeg vs libopus) should be left to the user by appropriate USE
> flag (the same as it is now with e.g. mp3, vorbis, aac).

yes, but see comment #2 : it is not the case...
Comment 6 Alexis Ballier gentoo-dev 2013-02-08 13:29:11 UTC
   08 Feb 2013; Alexis Ballier <aballier@gentoo.org> mplayer-9999.ebuild:
+  disable opus since it only controls opus support in internal ffmpeg which we
+  do not use, bug #434258
+