Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 434194 - www-client/links[directfb] should depend on media-libs/libpng
Summary: www-client/links[directfb] should depend on media-libs/libpng
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tim Harder
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-07 06:23 UTC by Tim Hoppen
Modified: 2012-09-07 09:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Suggested patch (links-2.7.1.patch,160 bytes, patch)
2012-09-07 06:27 UTC, Tim Hoppen 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Hoppen 2012-09-07 06:23:24 UTC 
When installing www-client/links with USE="directfb" on a fresh system without libpng installed, emerge fails with this snippet:

checking for png_create_info_struct in -lpng... no
configure: error: You need libpng to compile Links in graphics mode


Reproducible: Always
Comment 1 Tim Hoppen 2012-09-07 06:27:25 UTC 
Created attachment 323124 [details, diff]
Suggested patch

This patch fixes the libpng precompiler check by adding ${GRAPHICS_DEPEND} and therefore libpng to the dependencies if directfb useflag is set.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2012-09-07 09:50:38 UTC 
yes, you are right, and the patch is correct also

committed to portage for links-2.7 without revbump

thank you
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2012-09-07 09:54:50 UTC 
and bug 434210 for stabilizing 2.7 if you wanna track