Created attachment 322478 [details] introduce a debug use flag and conditionally get rid of debug messages Clementine's CMakeLists.txt contains a check whether CMAKE_BUILD_TYPE is "Release" that disables the printing of debugging messages when running clementine. However, since the build type on Gentoo is "Gentoo", this check of course fails. It would be nice if we could get rid of those messages for regular builds (maybe with a debug use flag in case somebody wants/needs them!?). I've attached an ebuild based on clementine-1.0.1-r2.ebuild that does just that; it runs sed over the CMakeLists.txt unless the debug use flag is set. There's probably a better way of doing this, but I don't know it :-)
*** Bug 433459 has been marked as a duplicate of this bug. ***
Should be fixed in multimedia overlay for 1.1.0_rc1 and 9999. After 1.1.0 release the fix will be in portage.
Created attachment 325970 [details] patch for ebuild, works fine for me ssuominen, please commit patch for clementine-1.0.1-r2.ebuild
+ 08 Oct 2012; Sergey Popov <pinkbyte@gentoo.org> clementine-1.0.1-r2.ebuild: + Supress debug output when USE='debug' is not set wrt bug #433098. Thanks to + Michael Niggli for discovering this issue and Nikoli for solving it Also i have added missing inherit on flag-o-matic eclass. Please, test and report
It is not missing, please remove second inherit from ebuild. make-utils.eclass does 'append-cppflags -DNDEBUG' when use debug is disabled and already has 'inherit toolchain-funcs multilib flag-o-matic base'
Nikoli, i know it, but there are two cons to do it: 1) developer's policy prefer direct inherits when using functions in ebuild; 2) repoman complains about using this without inheriting flag-o-matic.
